|WARNING| pw151099 [PATCH v3 08/36] net/e1000/base: correct formatting differences

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151099

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'offset >= nvm->word_size'
#325: FILE: drivers/net/intel/e1000/base/e1000_i225.c:560:
+	if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+	    (words == 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'words == 0'
#325: FILE: drivers/net/intel/e1000/base/e1000_i225.c:560:
+	if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) ||
+	    (words == 0)) {

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct e1000_hw *' should also have an identifier name
#336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:698:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:698:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:698:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16 *' should also have an identifier name
#336: FILE: drivers/net/intel/e1000/base/e1000_i225.c:698:
+	s32 (*read_op_ptr)(struct e1000_hw *, u16, u16, u16 *);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == e1000_media_type_copper'
#347: FILE: drivers/net/intel/e1000/base/e1000_i225.c:1014:
+		if ((hw->phy.media_type == e1000_media_type_copper) &&
+		    !(hw->dev_spec._i225.eee_disable) &&
+		     (speed != SPEED_10)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed != SPEED_10'
#347: FILE: drivers/net/intel/e1000/base/e1000_i225.c:1014:
+		if ((hw->phy.media_type == e1000_media_type_copper) &&
+		    !(hw->dev_spec._i225.eee_disable) &&
+		     (speed != SPEED_10)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->mac.type == e1000_i225'
#381: FILE: drivers/net/intel/e1000/base/e1000_mac.c:1650:
+		if ((hw->mac.type == e1000_i225) &&
 		    (status & E1000_STATUS_SPEED_2500)) {

total: 0 errors, 4 warnings, 5 checks, 375 lines checked