|WARNING| pw151155 [PATCH v7 08/28] net/rnp: add queue setup and release operations

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151155

_coding style issues_


WARNING:MEMORY_BARRIER: memory barrier without comment
#135: FILE: drivers/net/rnp/base/rnp_bdq_if.c:35:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#150: FILE: drivers/net/rnp/base/rnp_bdq_if.c:50:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#153: FILE: drivers/net/rnp/base/rnp_bdq_if.c:53:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#166: FILE: drivers/net/rnp/base/rnp_bdq_if.c:66:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#189: FILE: drivers/net/rnp/base/rnp_bdq_if.c:89:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#192: FILE: drivers/net/rnp/base/rnp_bdq_if.c:92:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#201: FILE: drivers/net/rnp/base/rnp_bdq_if.c:101:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#247: FILE: drivers/net/rnp/base/rnp_bdq_if.c:147:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#259: FILE: drivers/net/rnp/base/rnp_bdq_if.c:159:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#267: FILE: drivers/net/rnp/base/rnp_bdq_if.c:167:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#278: FILE: drivers/net/rnp/base/rnp_bdq_if.c:178:
+		udelay(10);

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#290: FILE: drivers/net/rnp/base/rnp_bdq_if.c:190:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#399: FILE: drivers/net/rnp/base/rnp_bdq_if.c:299:
+		wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#410: FILE: drivers/net/rnp/base/rnp_bdq_if.c:310:
+		wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#434: FILE: drivers/net/rnp/base/rnp_bdq_if.c:334:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#436: FILE: drivers/net/rnp/base/rnp_bdq_if.c:336:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#448: FILE: drivers/net/rnp/base/rnp_bdq_if.c:348:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#467: FILE: drivers/net/rnp/base/rnp_bdq_if.c:367:
+	rmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#480: FILE: drivers/net/rnp/base/rnp_bdq_if.c:380:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#482: FILE: drivers/net/rnp/base/rnp_bdq_if.c:382:
+	rmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#487: FILE: drivers/net/rnp/base/rnp_bdq_if.c:387:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#490: FILE: drivers/net/rnp/base/rnp_bdq_if.c:390:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#493: FILE: drivers/net/rnp/base/rnp_bdq_if.c:393:
+	rmb();

WARNING:TYPO_SPELLING: 'CLER' may be misspelled - perhaps 'CLEAR'?
#688: FILE: drivers/net/rnp/base/rnp_dma_regs.h:24:
+#define RNP_RXTX_IRQ_CLER(qid)	_RING_(0x0028 + 0x100 * (qid))

CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#747: FILE: drivers/net/rnp/base/rnp_hw.h:124:
+	spinlock_t rxq_reset_lock;

CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#748: FILE: drivers/net/rnp/base/rnp_hw.h:125:
+	spinlock_t txq_reset_lock;

WARNING:MEMORY_BARRIER: memory barrier without comment
#768: FILE: drivers/net/rnp/base/rnp_osdep.h:36:
+#define rmb()	rte_rmb()

total: 0 errors, 19 warnings, 8 checks, 1345 lines checked