|WARNING| pw151252 [PATCH v8 08/28] net/rnp: add queue setup and release operations

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151252

_coding style issues_


WARNING:MEMORY_BARRIER: memory barrier without comment
#134: FILE: drivers/net/rnp/base/rnp_bdq_if.c:35:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#149: FILE: drivers/net/rnp/base/rnp_bdq_if.c:50:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#152: FILE: drivers/net/rnp/base/rnp_bdq_if.c:53:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#165: FILE: drivers/net/rnp/base/rnp_bdq_if.c:66:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#188: FILE: drivers/net/rnp/base/rnp_bdq_if.c:89:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#191: FILE: drivers/net/rnp/base/rnp_bdq_if.c:92:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#200: FILE: drivers/net/rnp/base/rnp_bdq_if.c:101:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#246: FILE: drivers/net/rnp/base/rnp_bdq_if.c:147:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#258: FILE: drivers/net/rnp/base/rnp_bdq_if.c:159:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#266: FILE: drivers/net/rnp/base/rnp_bdq_if.c:167:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#277: FILE: drivers/net/rnp/base/rnp_bdq_if.c:178:
+		udelay(10);

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#289: FILE: drivers/net/rnp/base/rnp_bdq_if.c:190:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#398: FILE: drivers/net/rnp/base/rnp_bdq_if.c:299:
+		wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#409: FILE: drivers/net/rnp/base/rnp_bdq_if.c:310:
+		wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#433: FILE: drivers/net/rnp/base/rnp_bdq_if.c:334:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#435: FILE: drivers/net/rnp/base/rnp_bdq_if.c:336:
+	wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#447: FILE: drivers/net/rnp/base/rnp_bdq_if.c:348:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#466: FILE: drivers/net/rnp/base/rnp_bdq_if.c:367:
+	rmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#480: FILE: drivers/net/rnp/base/rnp_bdq_if.c:381:
+		udelay(10);

WARNING:MEMORY_BARRIER: memory barrier without comment
#482: FILE: drivers/net/rnp/base/rnp_bdq_if.c:383:
+	rmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#487: FILE: drivers/net/rnp/base/rnp_bdq_if.c:388:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#490: FILE: drivers/net/rnp/base/rnp_bdq_if.c:391:
+	wmb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#493: FILE: drivers/net/rnp/base/rnp_bdq_if.c:394:
+	rmb();

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'macaddr' - possible side-effects?
#661: FILE: drivers/net/rnp/base/rnp_common.h:9:
+#define RNP_GET_MAC_HI(macaddr) (((macaddr[0]) << 8) | (macaddr[1]))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'macaddr' - possible side-effects?
#662: FILE: drivers/net/rnp/base/rnp_common.h:10:
+#define RNP_GET_MAC_LO(macaddr) \
+	((macaddr[2] << 24) | (macaddr[3] << 16) | \
+	 ((macaddr[4] << 8)) | (macaddr[5]))

WARNING:TYPO_SPELLING: 'CLER' may be misspelled - perhaps 'CLEAR'?
#688: FILE: drivers/net/rnp/base/rnp_dma_regs.h:24:
+#define RNP_RXTX_IRQ_CLER(qid)	_RING_(0x0028 + 0x100 * (qid))

WARNING:MEMORY_BARRIER: memory barrier without comment
#768: FILE: drivers/net/rnp/base/rnp_osdep.h:37:
+#define rmb()	rte_rmb()

total: 0 errors, 19 warnings, 8 checks, 1346 lines checked