|WARNING| pw151409 [PATCH v12 04/28] net/rnp: support mailbox basic operate

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151409

_coding style issues_


WARNING:MEMORY_BARRIER: memory barrier without comment
#191: FILE: drivers/net/rnp/base/rnp_mbx.c:21:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#206: FILE: drivers/net/rnp/base/rnp_mbx.c:36:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#235: FILE: drivers/net/rnp/base/rnp_mbx.c:65:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#261: FILE: drivers/net/rnp/base/rnp_mbx.c:91:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#295: FILE: drivers/net/rnp/base/rnp_mbx.c:125:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#402: FILE: drivers/net/rnp/base/rnp_mbx.c:232:
+		wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#406: FILE: drivers/net/rnp/base/rnp_mbx.c:236:
+		udelay(100);

WARNING:MEMORY_BARRIER: memory barrier without comment
#472: FILE: drivers/net/rnp/base/rnp_mbx.c:302:
+	mb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#515: FILE: drivers/net/rnp/base/rnp_mbx.c:345:
+	udelay(300);

WARNING:MEMORY_BARRIER: memory barrier without comment
#516: FILE: drivers/net/rnp/base/rnp_mbx.c:346:
+	mb();

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#708: FILE: drivers/net/rnp/base/rnp_mbx.h:20:
+ *|------master-req-----|-------master-ack------|

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#708: FILE: drivers/net/rnp/base/rnp_mbx.h:20:
+ *|------master-req-----|-------master-ack------|

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#709: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------slave-req------|-------slave-ack-------|

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#709: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------slave-req------|-------slave-ack-------|

WARNING:MEMORY_BARRIER: memory barrier without comment
#774: FILE: drivers/net/rnp/base/rnp_osdep.h:22:
+#define mb()	rte_mb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#775: FILE: drivers/net/rnp/base/rnp_osdep.h:23:
+#define wmb()	rte_wmb()

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#787: FILE: drivers/net/rnp/base/rnp_osdep.h:35:
+	RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#787: FILE: drivers/net/rnp/base/rnp_osdep.h:35:
+	RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#794: FILE: drivers/net/rnp/base/rnp_osdep.h:42:
+	RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, val);

total: 0 errors, 14 warnings, 5 checks, 748 lines checked