|WARNING| pw151992 [PATCH v15 04/29] net/rnp: support mailbox basic operate

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151992

_coding style issues_


WARNING:MEMORY_BARRIER: memory barrier without comment
#194: FILE: drivers/net/rnp/base/rnp_mbx.c:21:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#209: FILE: drivers/net/rnp/base/rnp_mbx.c:36:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#238: FILE: drivers/net/rnp/base/rnp_mbx.c:65:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#264: FILE: drivers/net/rnp/base/rnp_mbx.c:91:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#298: FILE: drivers/net/rnp/base/rnp_mbx.c:125:
+	mb();

WARNING:MEMORY_BARRIER: memory barrier without comment
#405: FILE: drivers/net/rnp/base/rnp_mbx.c:232:
+		wmb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#409: FILE: drivers/net/rnp/base/rnp_mbx.c:236:
+		udelay(100);

WARNING:MEMORY_BARRIER: memory barrier without comment
#475: FILE: drivers/net/rnp/base/rnp_mbx.c:302:
+	mb();

CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#518: FILE: drivers/net/rnp/base/rnp_mbx.c:345:
+	udelay(300);

WARNING:MEMORY_BARRIER: memory barrier without comment
#519: FILE: drivers/net/rnp/base/rnp_mbx.c:346:
+	mb();

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#707: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------master-req-----|-------master-ack------|

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#707: FILE: drivers/net/rnp/base/rnp_mbx.h:21:
+ *|------master-req-----|-------master-ack------|

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#708: FILE: drivers/net/rnp/base/rnp_mbx.h:22:
+ *|------slave-req------|-------slave-ack-------|

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#708: FILE: drivers/net/rnp/base/rnp_mbx.h:22:
+ *|------slave-req------|-------slave-ack-------|

WARNING:MEMORY_BARRIER: memory barrier without comment
#773: FILE: drivers/net/rnp/base/rnp_osdep.h:22:
+#define mb()	rte_mb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#774: FILE: drivers/net/rnp/base/rnp_osdep.h:23:
+#define wmb()	rte_wmb()

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#786: FILE: drivers/net/rnp/base/rnp_osdep.h:35:
+	RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#786: FILE: drivers/net/rnp/base/rnp_osdep.h:35:
+	RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, v);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#793: FILE: drivers/net/rnp/base/rnp_osdep.h:42:
+	RNP_PMD_REG_LOG(DEBUG, "offset=%p val=%#"PRIx32"", offset, val);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#801: FILE: drivers/net/rnp/base/rnp_osdep.h:50:
+#define RNP_C_REG_WR(hw, off, value)	\
+	rnp_reg_write32((hw)->c_ctrl, ((off) & ((hw)->c_blen - 1)), (value))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#803: FILE: drivers/net/rnp/base/rnp_osdep.h:52:
+#define RNP_C_REG_RD(hw, off)		\
+	rnp_reg_read32((hw)->c_ctrl, ((off) & ((hw)->c_blen - 1)))

total: 0 errors, 14 warnings, 7 checks, 752 lines checked