|WARNING| pw151993 [PATCH v15 05/29] net/rnp: add device init and uninit

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/151993

_coding style issues_


WARNING:BAD_SIGN_OFF: Duplicate signature
#52: 
Signed-off-by: Wenbo Cao <caowenbo at mucse.com>

WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#586: FILE: drivers/net/rnp/base/rnp_hw.h:74:
+	bool msg_alloced;

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#592: FILE: drivers/net/rnp/base/rnp_hw.h:80:
+#define rnp_call_hwif_impl(port, f, arg...) \
+	(((f) != NULL) ? ((f) (port, arg)) : (-ENODEV))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1078: FILE: drivers/net/rnp/base/rnp_osdep.h:39:
+#define ffs(x) (rte_fls_u32((x) & (-x)))

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#1132: FILE: drivers/net/rnp/base/rnp_osdep.h:103:
+		snprintf(z_name, sizeof(z_name), "rnp_dma_%" PRIu64,

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1146: FILE: drivers/net/rnp/base/rnp_osdep.h:117:
+			"%"PRIu64, mz->name, mem->pa);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1156: FILE: drivers/net/rnp/base/rnp_osdep.h:127:
+			"%"PRIu64, ((const struct rte_memzone *)mem->mz)->name,

total: 0 errors, 2 warnings, 5 checks, 1423 lines checked
Warning in drivers/net/rnp/base/rnp_hw.h:
Do not use variadic argument pack in macros