|WARNING| pw150713 [PATCH v1 02/42] net/e1000/base: add initial support for i225

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jan 31 14:01:38 CET 2025


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/150713

_coding style issues_


CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#132: FILE: drivers/net/intel/e1000/base/e1000_api.h:22:
+extern void e1000_init_function_pointers_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#213: FILE: drivers/net/intel/e1000/base/e1000_i225.c:8:
+STATIC s32 e1000_init_phy_params_i225(struct e1000_hw *hw);

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#214: FILE: drivers/net/intel/e1000/base/e1000_i225.c:9:
+STATIC s32 e1000_reset_hw_i225(struct e1000_hw *hw);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#323: FILE: drivers/net/intel/e1000/base/e1000_i225.c:118:
+	ret_val = e1000_disable_pcie_master_generic(hw);

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#325: FILE: drivers/net/intel/e1000/base/e1000_i225.c:120:
+		DEBUGOUT("PCI-E Master disable polling has failed.
");

total: 0 errors, 4 warnings, 1 checks, 335 lines checked


More information about the test-report mailing list