|WARNING| pw155115 [RFC v2 06/12] ethdev: add port mirroring feature

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Jul 9 19:37:10 CEST 2025


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155115

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#158: FILE: lib/ethdev/ethdev_private.c:283:
+	fpo->rx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->rx_mirror;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#159: FILE: lib/ethdev/ethdev_private.c:284:
+	fpo->tx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->tx_mirror;

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#424: FILE: lib/ethdev/rte_ethdev_core.h:105:
+	RTE_ATOMIC(struct rte_eth_mirror *) *rx_mirror;
 	                                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#433: FILE: lib/ethdev/rte_ethdev_core.h:125:
+	RTE_ATOMIC(struct rte_eth_mirror *) *tx_mirror;
 	                                    ^

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#452: FILE: lib/ethdev/rte_mirror.c:9:
+#include <stdio.h>

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#504: FILE: lib/ethdev/rte_mirror.c:61:
+	if (rte_mbuf_dyn_tx_timestamp_register(&mbuf_timestamp_offset, &mbuf_timestamp_dynflag) < 0) {

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#587: FILE: lib/ethdev/rte_mirror.c:144:
+	    conf->direction > (RTE_ETH_MIRROR_DIRECTION_INGRESS | RTE_ETH_MIRROR_DIRECTION_EGRESS)) {

total: 4 errors, 3 warnings, 723 lines checked


More information about the test-report mailing list