|WARNING| pw154704 [PATCH v2 04/15] net/txgbe: add basic link configuration for Amber-Lite NICs

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154704

_coding style issues_


WARNING:TYPO_SPELLING: 'Lite' may be misspelled - perhaps 'Light'?
#77: 
Due to Amber-Lite's significant differences from our 10G NICs, we split

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#78: 
link configuration components (setup_link, check_link, etc.) into new files.

CHECK:BRACES: braces {} should be used on all arms of this statement
#182: FILE: drivers/net/txgbe/base/txgbe_aml.c:66:
+	if (link_up) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#193: FILE: drivers/net/txgbe/base/txgbe_aml.c:77:
+	} else

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'link_speed == TXGBE_LINK_SPEED_25GB_FULL'
#347: FILE: drivers/net/txgbe/base/txgbe_aml.c:231:
+		if ((link_speed == TXGBE_LINK_SPEED_25GB_FULL) && link_up)

WARNING:TYPO_SPELLING: 'repeatly' may be misspelled - perhaps 'repeatedly'?
#359: FILE: drivers/net/txgbe/base/txgbe_aml.c:243:
+		/*aml wait link in setup,no need to repeatly wait*/

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#366: FILE: drivers/net/txgbe/base/txgbe_aml.c:250:
+
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'link_speed == TXGBE_LINK_SPEED_10GB_FULL'
#376: FILE: drivers/net/txgbe/base/txgbe_aml.c:260:
+		if ((link_speed == TXGBE_LINK_SPEED_10GB_FULL) && link_up)

WARNING:TYPO_SPELLING: 'repeatly' may be misspelled - perhaps 'repeatedly'?
#387: FILE: drivers/net/txgbe/base/txgbe_aml.c:271:
+		/*aml wait link in setup,no need to repeatly wait*/

CHECK:BRACES: braces {} should be used on all arms of this statement
#540: FILE: drivers/net/txgbe/base/txgbe_aml40.c:67:
+	if (link_up) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#544: FILE: drivers/net/txgbe/base/txgbe_aml40.c:71:
+	} else

total: 0 errors, 4 warnings, 7 checks, 740 lines checked