|WARNING| pw153353 [PATCH v6 1/3] cmdline: use C standard library as number parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153353

_coding style issues_


WARNING:BRACES: braces {} are not necessary for any arm of this statement
#343: FILE: lib/cmdline/cmdline_parse_num.c:176:
+			if (c == '0') {
[...]
-			else if (c >= '1' && c <= '9') {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#353: FILE: lib/cmdline/cmdline_parse_num.c:179:
 			}
+			else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#353: FILE: lib/cmdline/cmdline_parse_num.c:179:
+			else {
 				st = ERROR;
 			}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#363: FILE: lib/cmdline/cmdline_parse_num.c:185:
+			if (c == 'b') {
[...]
-			else if (c >= '0' && c <= '7') {
[...]

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#567: FILE: lib/cmdline/cmdline_parse_num.c:267:
+	unsigned ressize)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#567: FILE: lib/cmdline/cmdline_parse_num.c:267:
+	unsigned ressize)

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#580: FILE: lib/cmdline/cmdline_parse_num.c:280:
+	if (res && check_res_size(&nd, ressize) < 0)

total: 1 errors, 6 warnings, 490 lines checked