|WARNING| pw158573 [RFC PATCH v2 01/33] eal: add more min/max helpers

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/158573

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#94: FILE: lib/eal/include/rte_common.h:805:
+#define RTE_MIN3(a, b, c)                      \
+	__extension__ ({                        \
+		typeof (a) _a = (a);            \
+		typeof (b) _b = (b);            \
+		typeof (c) _c = (c);            \
+		_a < _b ? (_a < _c ? _a : _c)   \
+		        : (_b < _c ? _b : _c);  \
+	})

BUT SEE:

   do {} while (0) advice is over-stated in a few situations:

   The more obvious case is macros, like MODULE_PARM_DESC, invoked at
   file-scope, where C disallows code (it must be in functions).  See
   $exceptions if you have one to add by name.

   More troublesome is declarative macros used at top of new scope,
   like DECLARE_PER_CPU.  These might just compile with a do-while-0
   wrapper, but would be incorrect.  Most of these are handled by
   detecting struct,union,etc declaration primitives in $exceptions.

   Theres also macros called inside an if (block), which "return" an
   expression.  These cannot do-while, and need a ({}) wrapper.

   Enjoy this qualification while we work to improve our heuristics.

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#96: FILE: lib/eal/include/rte_common.h:807:
+		typeof (a) _a = (a);            \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#97: FILE: lib/eal/include/rte_common.h:808:
+		typeof (b) _b = (b);            \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#98: FILE: lib/eal/include/rte_common.h:809:
+		typeof (c) _c = (c);            \

ERROR:CODE_INDENT: code indent should use tabs where possible
#100: FILE: lib/eal/include/rte_common.h:811:
+^I^I        : (_b < _c ? _b : _c);  \$

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#114: FILE: lib/eal/include/rte_common.h:830:
+		typeof (a) _ax = (a); \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#115: FILE: lib/eal/include/rte_common.h:831:
+		typeof (b) _bx = (b); \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#122: FILE: lib/eal/include/rte_common.h:838:
+#define RTE_MAX3(a, b, c)                      \
+	__extension__ ({                        \
+		typeof (a) _a = (a);            \
+		typeof (b) _b = (b);            \
+		typeof (c) _c = (c);            \
+		_a > _b ? (_a > _c ? _a : _c)   \
+		        : (_b > _c ? _b : _c);  \
 	})

BUT SEE:

   do {} while (0) advice is over-stated in a few situations:

   The more obvious case is macros, like MODULE_PARM_DESC, invoked at
   file-scope, where C disallows code (it must be in functions).  See
   $exceptions if you have one to add by name.

   More troublesome is declarative macros used at top of new scope,
   like DECLARE_PER_CPU.  These might just compile with a do-while-0
   wrapper, but would be incorrect.  Most of these are handled by
   detecting struct,union,etc declaration primitives in $exceptions.

   Theres also macros called inside an if (block), which "return" an
   expression.  These cannot do-while, and need a ({}) wrapper.

   Enjoy this qualification while we work to improve our heuristics.

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#124: FILE: lib/eal/include/rte_common.h:840:
+		typeof (a) _a = (a);            \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#125: FILE: lib/eal/include/rte_common.h:841:
+		typeof (b) _b = (b);            \

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#126: FILE: lib/eal/include/rte_common.h:842:
+		typeof (c) _c = (c);            \

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: lib/eal/include/rte_common.h:844:
+^I^I        : (_b > _c ? _b : _c);  \$

total: 4 errors, 8 warnings, 43 lines checked