|SUCCESS|dpdk|8dc7bf943f| intel-Functional

sys_stv at intel.com sys_stv at intel.com
Thu Oct 23 22:04:02 CEST 2025


Test-Label: intel-Functional
Test-Status: SUCCESS
_Functional PASS_

DPDK git repo: dpdk
commit 60280146fc7e552a2510be4e171de2e37fb03de6
Author: Wathsala Vithanage <wathsala.vithanage at arm.com>
Date:   Thu Oct 23 18:47:24 2025 +0000

    eal: correct memory ordering in MCS lock
    
    Fix incorrect memory ordering in the MCS lock implementation by
    adding proper synchronizing edges to establish clear happens-before
    relationships between threads invoking lock() and unlock(). These
    synchronizing edges prevent potential deadlocks caused by improper
    ordering and are documented in detail through in-code comments.
    
    The previously relaxed load of the successor’s lock object pointer
    in unlock() has been upgraded to a load-acquire operation. This
    change ensures that the successor’s initialization does not
    overwrite the current lock holder’s update to the locked field,
    which could otherwise lead to deadlocks.
    
    Remove two unnecessary fences:
    
    The acquire fence in unlock() had no matching release fence, making
    it ineffective for enforcing memory order. The associated comment
    suggested it prevented speculative reordering, but such fences (data
    memory barriers) only establish memory ordering and do not control
    instruction speculation.
    
    The release-acquire fence pair in lock() was previously justified as
    preventing reordering between the load-acquire loop of me->locked
    and the store-release of prev->next. This is no longer needed, as the
    new synchronizing edges ensure a chain of happens-before
    relationships between memory operations of threads calling lock() and
    unlock().
    
    Signed-off-by: Wathsala Vithanage <wathsala.vithanage at arm.com>
    Reviewed-by: Ola Liljedahl <ola.liljedahl at arm.com>

Smoke-Testing Summary : 31 Case Done, 31 Successful, 0 Failures      


OS : Ubuntu 22.04.2 LTS       
Kernel : 5.15.0-60-generic         
GCC : 11.3.0-1ubuntu1~22.04        
NIC : Ethernet Controller XL710 for 40GbE QSFP+         
Target : x86_64-native-linuxapp-gcc      

	Test result details:
	+-----------------+---------------------------------------------------+-------+
	| suite           | case                                              | status|
	+-----------------+---------------------------------------------------+-------+
	| checksum_offload| test_checksum_offload_with_vlan                   | passed|
	| checksum_offload| test_do_not_insert_checksum_on_the_transmit_packet| passed|
	| checksum_offload| test_hardware_checksum_check_ip_rx                | passed|
	| checksum_offload| test_hardware_checksum_check_ip_tx                | passed|
	| checksum_offload| test_hardware_checksum_check_l4_rx                | passed|
	| checksum_offload| test_insert_checksum_on_the_transmit_packet       | passed|
	| checksum_offload| test_rx_checksum_valid_flags                      | passed|
	| checksum_offload| test_hardware_checksum_check_l4_tx                | n/a   |
	| dual_vlan       | test_dual_vlan_priority_rxtx                      | passed|
	| dual_vlan       | test_vlan_filter_config                           | passed|
	| dual_vlan       | test_vlan_filter_table                            | passed|
	| dual_vlan       | test_vlan_insert_config                           | passed|
	| dual_vlan       | test_vlan_random_test                             | passed|
	| dual_vlan       | test_vlan_strip_config                            | passed|
	| dual_vlan       | test_vlan_synthetic_test                          | passed|
	| dual_vlan       | test_vlan_tpid_config                             | passed|
	| dual_vlan       | test_vlan_stripq_config                           | n/a   |
	| jumboframes     | test_jumboframes_bigger_jumbo                     | passed|
	| jumboframes     | test_jumboframes_jumbo_jumbo                      | passed|
	| jumboframes     | test_jumboframes_jumbo_nojumbo                    | passed|
	| jumboframes     | test_jumboframes_normal_jumbo                     | passed|
	| jumboframes     | test_jumboframes_normal_nojumbo                   | passed|
	| rxtx_offload    | test_rxoffload_port_all                           | passed|
	| rxtx_offload    | test_rxoffload_port_cmdline                       | passed|
	| rxtx_offload    | test_txoffload_port                               | passed|
	| rxtx_offload    | test_txoffload_port_all                           | passed|
	| rxtx_offload    | test_txoffload_port_checksum                      | passed|
	| rxtx_offload    | test_txoffload_port_cmdline                       | passed|
	| rxtx_offload    | test_rxoffload_queue                              | n/a   |
	| rxtx_offload    | test_txoffload_port_multi_segs                    | n/a   |
	| rxtx_offload    | test_txoffload_queue                              | n/a   |
	+-----------------+---------------------------------------------------+-------+


DPDK STV team


More information about the test-report mailing list