|WARNING| pw156805 [PATCH] net/tap: fix build with LTO
checkpatch at dpdk.org
checkpatch at dpdk.org
Mon Sep 22 09:29:26 CEST 2025
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/156805
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#403: FILE: drivers/net/tap/tap_netlink.h:26:
+#define NLMSG_TAIL(msg) (void *)((char *)(msg) + NLMSG_ALIGN((msg)->nh.nlmsg_len))
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at
file-scope, where C disallows code (it must be in functions). See
$exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope,
like DECLARE_PER_CPU. These might just compile with a do-while-0
wrapper, but would be incorrect. Most of these are handled by
detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an
expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'msg' - possible side-effects?
#403: FILE: drivers/net/tap/tap_netlink.h:26:
+#define NLMSG_TAIL(msg) (void *)((char *)(msg) + NLMSG_ALIGN((msg)->nh.nlmsg_len))
total: 1 errors, 0 warnings, 1 checks, 319 lines checked
More information about the test-report
mailing list