|SUCCESS| net/i40e: reduce debug messages
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Tue Apr 14 16:33:10 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163023
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-14
git sha: (from patch metadata, commit hash not directly available in patch)
Author: Stephen Hemminger <stephen at networkplumber.org>
Subject: [PATCH] net/i40e: reduce debug messages
This commit changes the log level for Rx/Tx path selection messages
from NOTICE to DEBUG in the i40e driver.
> diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
> index c5ac75e0f0..d00548ac89 100644
> --- a/drivers/net/intel/i40e/i40e_rxtx.c
> +++ b/drivers/net/intel/i40e/i40e_rxtx.c
> @@ -3042,7 +3042,7 @@ i40e_set_rx_function(struct rte_eth_dev *dev)
>
> out:
> dev->rx_pkt_burst = i40e_rx_path_infos[ad->rx_func_type].pkt_burst;
> - PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> + PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
> i40e_rx_path_infos[ad->rx_func_type].info, dev->data->port_id);
Does this ensure sufficient visibility of important configuration
information for production environments? Typically, path selection
information (e.g., use of AVX optimizations) is considered operationally
significant and might be useful at INFO level rather than DEBUG, as
administrators often want to know which code paths are active without
enabling verbose debugging.
> }
>
> @@ -3124,7 +3124,7 @@ i40e_set_tx_function(struct rte_eth_dev *dev)
> i40e_tx_path_infos[ad->tx_func_type].pkt_burst;
> dev->tx_pkt_prepare = i40e_tx_path_infos[ad->tx_func_type].pkt_prep;
>
> - PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> + PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
> i40e_tx_path_infos[ad->tx_func_type].info, dev->data->port_id);
Does changing this to DEBUG level cause issues for users who need to
verify their hardware is using accelerated paths? Performance tuning
often requires confirmation that vector/SIMD paths are active, which
would be hidden at DEBUG level.
Consider whether INFO level might be more appropriate than DEBUG for
these path selection messages, as they represent significant operational
state rather than detailed debugging information.
More information about the test-report
mailing list