|SUCCESS| [v2] common/mlx5: add ConnectX-10 SmartNIC

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163218

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-20

I have reviewed the patch for compliance with DPDK coding standards and
contribution guidelines. Below is my analysis:

git sha: 20260420104856.14187-1-rasland at nvidia.com
Author: Raslan Darawsheh <rasland at nvidia.com>
Subject: [PATCH v2] common/mlx5: add ConnectX-10 SmartNIC

This patch adds the ConnectX-10 SmartNIC device ID to the list of NVIDIA
devices supported by mlx5 drivers. The device is still in development
stage.

> diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h
> index 47fcc3fb06..3e66c9e6c8 100644
> --- a/drivers/common/mlx5/mlx5_common.h
> +++ b/drivers/common/mlx5/mlx5_common.h
> @@ -156,6 +156,7 @@ enum {
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX8 = 0x1023,
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX9 = 0x1025,
>  	PCI_DEVICE_ID_MELLANOX_BLUEFIELD4 = 0xa2df,
> +	PCI_DEVICE_ID_MELLANOX_CONNECTX10 = 0x1027,
>  };

Does the numerical ordering here follow the expected device generation
sequence? The BLUEFIELD4 ID (0xa2df) is placed between CONNECTX9 (0x1025)
and CONNECTX10 (0x1027), but the value 0xa2df is much larger. Should
CONNECTX10 be placed before BLUEFIELD4 to maintain logical device
generation ordering, or is this intentional grouping by ID value range?

> diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c
> index 240e8bb858..dd0aabb6d7 100644
> --- a/drivers/crypto/mlx5/mlx5_crypto.c
> +++ b/drivers/crypto/mlx5/mlx5_crypto.c
> @@ -495,6 +495,10 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = {
>  			RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
>  					PCI_DEVICE_ID_MELLANOX_BLUEFIELD4)
>  		},
> +		{
> +			RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +					PCI_DEVICE_ID_MELLANOX_CONNECTX10)
> +		},

[ ... ]

> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index c24c9b306d..f190654756 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -3925,6 +3925,10 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {
>  		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
>  				PCI_DEVICE_ID_MELLANOX_BLUEFIELD4)
>  	},
> +	{
> +		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> +				PCI_DEVICE_ID_MELLANOX_CONNECTX10)
> +	},

The patch correctly adds the new device ID to all three locations
(common header, crypto driver, and net driver) maintaining consistency
across the codebase. The formatting follows the existing pattern with
proper indentation and structure.

Since the commit message indicates the device is still in development
stage, has this been validated with actual hardware or is this a
preparatory patch for future hardware availability?