|SUCCESS| tree-wide: fix 'allow[s] to' grammar

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Wed Apr 22 19:11:16 CEST 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163236

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-22

I'll review this patch for code quality, potential bugs, and compliance with DPDK coding standards.

commit f9ff3daa88
Author: Luca Boccassi <luca.boccassi at gmail.com>
tree-wide: fix 'allow[s] to' grammar

This patch fixes grammatical issues by replacing "allow[s] to" with
either the gerundive form or "allow[s] one to" across documentation,
comments and code.

> diff --git a/doc/guides/linux_gsg/linux_drivers.rst b/doc/guides/linux_gsg/linux_drivers.rst
> index a7d64d486c..8b117f92c2 100644
> --- a/doc/guides/linux_gsg/linux_drivers.rst
> +++ b/doc/guides/linux_gsg/linux_drivers.rst

[ ... ]

> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index a144f43336..48543f2c76 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst

[ ... ]

> diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
> index a981d0be5e..259af6a0df 100644
> --- a/drivers/common/sfc_efx/base/efx_regs_mcdi.h
> +++ b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
> @@ -28619,7 +28619,7 @@
>  #define	MC_CMD_PRIVILEGE_MASK_IN_GRP_BROADCAST 0x100 /* enum */
>  #define	MC_CMD_PRIVILEGE_MASK_IN_GRP_ALL_MULTICAST 0x200 /* enum */
>  #define	MC_CMD_PRIVILEGE_MASK_IN_GRP_PROMISCUOUS 0x400 /* enum */
> -/* enum: Allows to set the TX packets' source MAC address to any arbitrary MAC
> +/* enum: Allows setting the TX packets' source MAC address to any arbitrary MAC
>   * adress.
>   */
>  #define	MC_CMD_PRIVILEGE_MASK_IN_GRP_MAC_SPOOFING_TX 0x800

Does this code now have a spelling error that was already present? The
comment contains "adress" which should be "address".

> diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
> index 0a356abae2..71415346cf 100644
> --- a/lib/eal/include/rte_common.h
> +++ b/lib/eal/include/rte_common.h
> @@ -356,7 +356,7 @@ typedef uint16_t unaligned_uint16_t;
>   *   Priority number must be above 100.
>   *   Lowest number is the first to run.
>   */
> -#ifndef RTE_INIT_PRIO /* Allow to override from EAL */
> +#ifndef RTE_INIT_PRIO /* Allow overriding from EAL */
>  #ifndef RTE_TOOLCHAIN_MSVC
>  #define RTE_INIT_PRIO(func, prio) \
>  static void __attribute__((constructor(RTE_PRIO(prio)), used)) func(void)
> @@ -402,7 +402,7 @@ typedef int(__cdecl *_PIFV)(void);
>   *   Priority number must be above 100.
>   *   Lowest number is the last to run.
>   */
> -#ifndef RTE_FINI_PRIO /* Allow to override from EAL */
> +#ifndef RTE_FINI_PRIO /* Allow overriding from EAL */
>  #ifndef RTE_TOOLCHAIN_MSVC
>  #define RTE_FINI_PRIO(func, prio) \
>  static void __attribute__((destructor(RTE_PRIO(prio)), used)) func(void)

[ ... ]

> diff --git a/lib/graph/graph.c b/lib/graph/graph.c
> index 6911ea8abe..5f8ada2185 100644
> --- a/lib/graph/graph.c
> +++ b/lib/graph/graph.c
> @@ -569,7 +569,7 @@ graph_clone(struct graph *parent_graph, const char *name, struct rte_graph_param
>  
>  	graph_spinlock_lock();
>  
> -	/* Don't allow to clone a node from a cloned graph */
> +	/* Don't allow cloning a node from a cloned graph */
>  	if (parent_graph->parent_id != RTE_GRAPH_ID_INVALID)
>  		SET_ERR_JMP(EEXIST, fail, "A cloned graph is not allowed to be cloned");

Does this comment accurately describe what the code checks? The comment
says "clone a node" but the code appears to check whether parent_graph
itself is cloned, not whether we're cloning a node. Should this say
"Don't allow cloning a graph from a cloned graph" instead?

> diff --git a/lib/graph/node.c b/lib/graph/node.c
> index e3359fe490..1fce3e6632 100644
> --- a/lib/graph/node.c
> +++ b/lib/graph/node.c
> @@ -188,7 +188,7 @@ node_clone(struct node *node, const char *name)
>  	struct rte_node_register *reg;
>  	rte_edge_t i;
>  
> -	/* Don't allow to clone a node from a cloned node */
> +	/* Don't allow cloning a node from a cloned node */
>  	if (node->parent_id != RTE_NODE_ID_INVALID) {
>  		rte_errno = EEXIST;
>  		goto fail;

[ ... ]


More information about the test-report mailing list