|WARNING| pw163257 [PATCH 16/18] net/txgbe: fix SFP module identification

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 23 05:41:50 CEST 2026


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/163257

_coding style issues_


WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#162: FILE: drivers/net/txgbe/base/txgbe_phy.c:923:
+	} else if (comp_codes_25g == TXGBE_SFF_25GAUI_C2M_AOC_BER_5 ||
[...]
+			hw->dac_sfp = false;

ERROR:SPACING: space prohibited before that ',' (ctx:WxV)
#637: FILE: drivers/net/txgbe/base/txgbe_phy.h:507:
+s32 txgbe_read_i2c_sff8636(struct txgbe_hw *hw, u8 page ,u8 byte_offset,
                                                         ^

ERROR:SPACING: space required after that ',' (ctx:WxV)
#637: FILE: drivers/net/txgbe/base/txgbe_phy.h:507:
+s32 txgbe_read_i2c_sff8636(struct txgbe_hw *hw, u8 page ,u8 byte_offset,
                                                         ^

WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 2 errors, 2 warnings, 0 checks, 531 lines checked


More information about the test-report mailing list