|WARNING| pw163254 [PATCH 13/18] net/txgbe: fix link stability for 40G NIC

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 23 05:43:39 CEST 2026
Previous message (by thread): |WARNING| pw163256 [PATCH 14/18] net/txgbe: fix link stability for Amber-Lite backplane mode
Next message (by thread): |WARNING| pw163253 [PATCH 12/18] net/txgbe: fix link stability for 25G NIC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/163254

_coding style issues_


WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#281: FILE: drivers/net/txgbe/base/txgbe_e56.c:177:
+	/* CMS Config Master */
 	              ^^^^^^

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#302: FILE: drivers/net/txgbe/base/txgbe_e56.c:198:
+	/* TXS Config Master */
 	              ^^^^^^

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#338: FILE: drivers/net/txgbe/base/txgbe_e56.c:234:
+	/* RXS Config master */
 	              ^^^^^^

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#443: FILE: drivers/net/txgbe/base/txgbe_e56.c:339:
+		set_fields_e56(&rdata, E56PHY_RXS_CTLE_TRAINING_2_ISI_TH_FRAC_P1, S10G_PHY_RX_CTLE_TAP_FRACP1);

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#444: FILE: drivers/net/txgbe/base/txgbe_e56.c:340:
+		set_fields_e56(&rdata, E56PHY_RXS_CTLE_TRAINING_2_ISI_TH_FRAC_P2, S10G_PHY_RX_CTLE_TAP_FRACP2);

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#445: FILE: drivers/net/txgbe/base/txgbe_e56.c:341:
+		set_fields_e56(&rdata, E56PHY_RXS_CTLE_TRAINING_2_ISI_TH_FRAC_P3, S10G_PHY_RX_CTLE_TAP_FRACP3);

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#450: FILE: drivers/net/txgbe/base/txgbe_e56.c:346:
+		set_fields_e56(&rdata, E56PHY_RXS_CTLE_TRAINING_3_TAP_WEIGHT_P1, S10G_PHY_RX_CTLE_TAPWT_WEIGHT1);

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#451: FILE: drivers/net/txgbe/base/txgbe_e56.c:347:
+		set_fields_e56(&rdata, E56PHY_RXS_CTLE_TRAINING_3_TAP_WEIGHT_P2, S10G_PHY_RX_CTLE_TAPWT_WEIGHT2);

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#452: FILE: drivers/net/txgbe/base/txgbe_e56.c:348:
+		set_fields_e56(&rdata, E56PHY_RXS_CTLE_TRAINING_3_TAP_WEIGHT_P3, S10G_PHY_RX_CTLE_TAPWT_WEIGHT3);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#459: FILE: drivers/net/txgbe/base/txgbe_e56.c:355:
+		set_fields_e56(&rdata, E56PHY_RXS_OFFSET_N_GAIN_CAL_0_FE_OFFSET_DAC_CLK_CNT_X8, 0xc);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#506: FILE: drivers/net/txgbe/base/txgbe_e56.c:402:
+		set_fields_e56(&rdata, E56PHY_RXS_ANA_OVRDEN_1_OVRD_EN_ANA_BBCDR_VCOFILT_BYP_I, 0x1);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#547: FILE: drivers/net/txgbe/base/txgbe_e56.c:443:
+	/* PDIG Config master */
 	               ^^^^^^

ERROR:SPACING: space prohibited before that close parenthesis ')'
#694: FILE: drivers/net/txgbe/base/txgbe_e56.c:1708:
+		if (speed == TXGBE_LINK_SPEED_10GB_FULL || speed == TXGBE_LINK_SPEED_40GB_FULL ) {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#694: FILE: drivers/net/txgbe/base/txgbe_e56.c:1708:
+		if (speed == TXGBE_LINK_SPEED_10GB_FULL || speed == TXGBE_LINK_SPEED_40GB_FULL ) {
[...]
+		} else if (speed == TXGBE_LINK_SPEED_25GB_FULL) {
[...]

WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see function description of msleep().
#719: FILE: drivers/net/txgbe/base/txgbe_e56.c:1733:
+			msleep(10);

CHECK:CAMELCASE: Avoid CamelCase: <arraySize>
#746: FILE: drivers/net/txgbe/base/txgbe_e56.c:1778:
+	int arraySize, RXS_BBCDR_SECOND_ORDER_ST[5];

WARNING:LONG_LINE_COMMENT: line length of 129 exceeds 100 columns
#754: FILE: drivers/net/txgbe/base/txgbe_e56.c:1786:
+	/* As status update from RXS hardware is asynchronous to read status of SECOND_ORDER, follow sequence mentioned below. */

WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#757: FILE: drivers/net/txgbe/base/txgbe_e56.c:1789:
+		/* set RXS_BBCDR_SECOND_ORDER_ST[i] = RXS::ANA_OVRDVAL[5]::ana_bbcdr_int_cstm_i[4:0] */

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#760: FILE: drivers/net/txgbe/base/txgbe_e56.c:1792:
+		RXS_BBCDR_SECOND_ORDER_ST[i] = EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_int_cstm_i);

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(RXS_BBCDR_SECOND_ORDER_ST)
#765: FILE: drivers/net/txgbe/base/txgbe_e56.c:1797:
+	arraySize = sizeof(RXS_BBCDR_SECOND_ORDER_ST) / sizeof(RXS_BBCDR_SECOND_ORDER_ST[0]);

ERROR:SPACING: space prohibited before that close parenthesis ')'
#768: FILE: drivers/net/txgbe/base/txgbe_e56.c:1800:
+	median = ((N + 1) / 2 ) - 1;

ERROR:SPACING: space required before the open brace '{'
#824: FILE: drivers/net/txgbe/base/txgbe_e56.c:1876:
+	for (i = 0; i < 4; i++){

ERROR:SPACING: space required before the open parenthesis '('
#825: FILE: drivers/net/txgbe/base/txgbe_e56.c:1877:
+		if(speed == TXGBE_LINK_SPEED_10GB_FULL || speed == TXGBE_LINK_SPEED_40GB_FULL) {

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#840: FILE: drivers/net/txgbe/base/txgbe_e56.c:1892:
+^I^I} ^I^Ielse if (speed == TXGBE_LINK_SPEED_25GB_FULL) {$

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#885: FILE: drivers/net/txgbe/base/txgbe_e56.c:1937:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_ultrafine_i) = ULTRAFINE_CODE + 1;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#891: FILE: drivers/net/txgbe/base/txgbe_e56.c:1943:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDEN_1, ovrd_en_ana_bbcdr_ultrafine_i) = 1;

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#896: FILE: drivers/net/txgbe/base/txgbe_e56.c:1948:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_ultrafine_i) = CMVAR_UFINE_UMAX_WRAP;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#897: FILE: drivers/net/txgbe/base/txgbe_e56.c:1949:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_fine_i) = FINE_CODE + 1;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#902: FILE: drivers/net/txgbe/base/txgbe_e56.c:1954:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDEN_1, ovrd_en_ana_bbcdr_ultrafine_i) = 1;

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#907: FILE: drivers/net/txgbe/base/txgbe_e56.c:1959:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_ultrafine_i) = CMVAR_UFINE_FMAX_WRAP;

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#908: FILE: drivers/net/txgbe/base/txgbe_e56.c:1960:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_fine_i) = CMVAR_FINE_FMAX_WRAP;

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#909: FILE: drivers/net/txgbe/base/txgbe_e56.c:1961:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_coarse_i) = COARSE_CODE + 1;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#916: FILE: drivers/net/txgbe/base/txgbe_e56.c:1968:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDEN_1, ovrd_en_ana_bbcdr_ultrafine_i) = 1;

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#925: FILE: drivers/net/txgbe/base/txgbe_e56.c:1977:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_ultrafine_i) = ULTRAFINE_CODE - 1;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#930: FILE: drivers/net/txgbe/base/txgbe_e56.c:1982:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDEN_1, ovrd_en_ana_bbcdr_ultrafine_i) = 1;

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#935: FILE: drivers/net/txgbe/base/txgbe_e56.c:1987:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_ultrafine_i) = CMVAR_UFINE_UMIN_WRAP;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#936: FILE: drivers/net/txgbe/base/txgbe_e56.c:1988:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_fine_i) = FINE_CODE - 1;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#942: FILE: drivers/net/txgbe/base/txgbe_e56.c:1994:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDEN_1, ovrd_en_ana_bbcdr_ultrafine_i) = 1;

WARNING:LONG_LINE: line length of 115 exceeds 100 columns
#947: FILE: drivers/net/txgbe/base/txgbe_e56.c:1999:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_ultrafine_i) = CMVAR_UFINE_FMIN_WRAP;

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#948: FILE: drivers/net/txgbe/base/txgbe_e56.c:2000:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_fine_i) = CMVAR_FINE_FMIN_WRAP;

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#949: FILE: drivers/net/txgbe/base/txgbe_e56.c:2001:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDVAL_5, ana_bbcdr_coarse_i) = COARSE_CODE - 1;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#956: FILE: drivers/net/txgbe/base/txgbe_e56.c:2008:
+				EPHY_XFLD(E56G__RXS0_ANA_OVRDEN_1, ovrd_en_ana_bbcdr_ultrafine_i) = 1;

CHECK:CAMELCASE: Avoid CamelCase: <bypassCtle>
#1080: FILE: drivers/net/txgbe/base/txgbe_e56.c:2264:
+	u32 bypassCtle = true;

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1091: FILE: drivers/net/txgbe/base/txgbe_e56.c:2275:
+		set_fields_e56(&rdata, E56PHY_RXS0_OVRDEN_2_OVRD_EN_RXS0_RX0_ADC_OFST_ADAPT_EN_I, 0x1);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1101: FILE: drivers/net/txgbe/base/txgbe_e56.c:2285:
+		set_fields_e56(&rdata, E56PHY_RXS0_OVRDEN_2_OVRD_EN_RXS0_RX0_ADC_GAIN_ADAPT_EN_I, 0x1);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#1112: FILE: drivers/net/txgbe/base/txgbe_e56.c:2296:
+		set_fields_e56(&rdata, E56PHY_RXS0_OVRDEN_1_OVRD_EN_RXS0_RX0_ADC_INTL_CAL_EN_I, 0x1);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1122: FILE: drivers/net/txgbe/base/txgbe_e56.c:2306:
+		set_fields_e56(&rdata, E56PHY_RXS0_OVRDEN_1_OVRD_EN_RXS0_RX0_ADC_INTL_CAL_DONE_O, 0x1);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1132: FILE: drivers/net/txgbe/base/txgbe_e56.c:2316:
+		set_fields_e56(&rdata, E56PHY_RXS0_OVRDEN_2_OVRD_EN_RXS0_RX0_ADC_INTL_ADAPT_EN_I, 0x1);

WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 100 columns
#1140: FILE: drivers/net/txgbe/base/txgbe_e56.c:2324:
+	 * 2. Follow sequence described in 2.3.2 RXS Osc Initialization for temperature tracking range

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#1141: FILE: drivers/net/txgbe/base/txgbe_e56.c:2325:
+	 * here. RXS would be enabled at the end of this sequence. For the case when PAM4 KR training

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#1202: FILE: drivers/net/txgbe/base/txgbe_e56.c:2386:
+		/* 4. Disable VGA and CTLE training so that they don't interfere with ADC calibration */

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1229: FILE: drivers/net/txgbe/base/txgbe_e56.c:2413:
+		set_fields_e56(&rdata, E56PHY_RXS0_OVRDEN_1_OVRD_EN_RXS0_RX0_ADC_INTL_CAL_DONE_O, 0x0);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1239: FILE: drivers/net/txgbe/base/txgbe_e56.c:2423:
+		while (((rdata >>  E56PHY_RXS0_OVRDVAL_1_RXS0_RX0_ADC_INTL_CAL_DONE_O_LSB) & 1) != 1) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1243: FILE: drivers/net/txgbe/base/txgbe_e56.c:2427:
+			if (timer++ > PHYINIT_TIMEOUT) {
+				break;
+			}

WARNING:LONG_LINE_COMMENT: line length of 136 exceeds 100 columns
#1248: FILE: drivers/net/txgbe/base/txgbe_e56.c:2432:
+		/* 6. Perform ADC offset adaptation and ADC gain adaptation, repeat them a few times and after that keep it disabled. */

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1253: FILE: drivers/net/txgbe/base/txgbe_e56.c:2437:
+			set_fields_e56(&rdata, E56PHY_RXS0_OVRDVAL_1_RXS0_RX0_ADC_OFST_ADAPT_EN_I, 0x1);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1259: FILE: drivers/net/txgbe/base/txgbe_e56.c:2443:
+			EPHY_XFLD(E56G__PMD_RXS0_OVRDEN_2, ovrd_en_rxs0_rx0_adc_ofst_adapt_done_o) = 0;

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#1265: FILE: drivers/net/txgbe/base/txgbe_e56.c:2449:
+			while (EPHY_XFLD(E56G__PMD_RXS0_OVRDVAL_1, rxs0_rx0_adc_ofst_adapt_done_o) != 1) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1268: FILE: drivers/net/txgbe/base/txgbe_e56.c:2452:
+				if (timer++ > PHYINIT_TIMEOUT) {
+					break;
+				}

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1277: FILE: drivers/net/txgbe/base/txgbe_e56.c:2461:
+			set_fields_e56(&rdata, E56PHY_RXS0_OVRDVAL_1_RXS0_RX0_ADC_OFST_ADAPT_EN_I, 0x0);

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1284: FILE: drivers/net/txgbe/base/txgbe_e56.c:2468:
+			set_fields_e56(&rdata, E56PHY_RXS0_OVRDVAL_1_RXS0_RX0_ADC_GAIN_ADAPT_EN_I, 0x1);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1290: FILE: drivers/net/txgbe/base/txgbe_e56.c:2474:
+			EPHY_XFLD(E56G__PMD_RXS0_OVRDEN_2, ovrd_en_rxs0_rx0_adc_ofst_adapt_done_o) = 0;

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#1296: FILE: drivers/net/txgbe/base/txgbe_e56.c:2480:
+			while (EPHY_XFLD(E56G__PMD_RXS0_OVRDVAL_1, rxs0_rx0_adc_gain_adapt_done_o) != 1) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1300: FILE: drivers/net/txgbe/base/txgbe_e56.c:2484:
+				if (timer++ > PHYINIT_TIMEOUT) {
+					break;
+				}

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1308: FILE: drivers/net/txgbe/base/txgbe_e56.c:2492:
+			set_fields_e56(&rdata, E56PHY_RXS0_OVRDVAL_1_RXS0_RX0_ADC_GAIN_ADAPT_EN_I, 0x0);

WARNING:LONG_LINE_COMMENT: line length of 106 exceeds 100 columns
#1320: FILE: drivers/net/txgbe/base/txgbe_e56.c:2498:
+		/* 7. Perform ADC interleaver adaptation for 10ms or greater, and after that disable it */

WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see function description of msleep().
#1327: FILE: drivers/net/txgbe/base/txgbe_e56.c:2505:
+		msleep(10);

WARNING:LONG_LINE_COMMENT: line length of 135 exceeds 100 columns
#1340: FILE: drivers/net/txgbe/base/txgbe_e56.c:2513:
+		/* 8. Now re-enable VGA and CTLE trainings, so that it continues to adapt tracking changes in temperature or voltage */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1344: FILE: drivers/net/txgbe/base/txgbe_e56.c:2517:
+		if (bypassCtle == 0) {
+			EPHY_XFLD(E56G__PMD_RXS0_OVRDVAL_1, rxs0_rx0_ctle_train_en_i) = 1;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1378: FILE: drivers/net/txgbe/base/txgbe_e56.c:2534:
+			if (timer++ > PHYINIT_TIMEOUT) {
+				break;
+			}

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#1411: FILE: drivers/net/txgbe/base/txgbe_e56.c:2548:
+			while (EPHY_XFLD(E56G__PMD_RXS0_OVRDVAL_1, rxs0_rx0_ctle_train_done_o) != 1) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1415: FILE: drivers/net/txgbe/base/txgbe_e56.c:2552:
+				if (timer++ > PHYINIT_TIMEOUT) {
+					break;
+				}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1426: FILE: drivers/net/txgbe/base/txgbe_e56.c:2563:
+		if (bypassCtle == 0) {
+			EPHY_XFLD(E56G__PMD_RXS0_OVRDEN_1, ovrd_en_rxs0_rx0_ctle_train_en_i) = 0;
+		}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1611: FILE: drivers/net/txgbe/base/txgbe_e56.c:3098:
+^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#1627: FILE: drivers/net/txgbe/base/txgbe_e56.c:3114:
+^I$

WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 6 errors, 68 warnings, 2 checks, 1666 lines checked
Previous message (by thread): |WARNING| pw163256 [PATCH 14/18] net/txgbe: fix link stability for Amber-Lite backplane mode
Next message (by thread): |WARNING| pw163253 [PATCH 12/18] net/txgbe: fix link stability for 25G NIC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list