|WARNING| pw163336 [PATCH 1/2] net/mana: add device reset support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/163336

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#79: 
The driver uses RTE_ETH_EVENT_ERR_RECOVERING, RTE_ETH_EVENT_RECOVERY_SUCCESS,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#158: FILE: drivers/net/mana/mana.c:267:
+	enum mana_device_state state = rte_atomic_load_explicit(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#199: FILE: drivers/net/mana/mana.c:309:
+	enum mana_device_state state = rte_atomic_load_explicit(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#235: FILE: drivers/net/mana/mana.c:335:
+	state = rte_atomic_load_explicit(

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_arg' - possible side-effects?
#472: FILE: drivers/net/mana/mana.c:1064:
+#define MANA_OPS_3_LOCK(_func, _arg)					\
+static void								\
+_func##_lock(struct rte_eth_dev *dev, uint16_t _arg)			\
+{									\
+	struct mana_priv *priv = dev->data->dev_private;		\
+	if (rte_spinlock_trylock(&priv->reset_ops_lock)) {		\
+		if (rte_atomic_load_explicit(&priv->dev_state,		\
+		    rte_memory_order_acquire) !=				\
+		    MANA_DEV_ACTIVE) {					\
+			rte_spinlock_unlock(&priv->reset_ops_lock);	\
+			DRV_LOG(ERR, "Device reset in progress, "	\
+				"%s not called", #_func);		\
+			return;						\
+		}							\
+		_func(dev, _arg);					\
+		rte_spinlock_unlock(&priv->reset_ops_lock);		\
+	} else {							\
+		DRV_LOG(ERR, "Device reset in progress, "		\
+			"%s not called", #_func);			\
+	}								\
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_arg' - possible side-effects?
#499: FILE: drivers/net/mana/mana.c:1091:
+#define MANA_OPS_4_LOCK(_func, _arg)					\
+static int								\
+_func##_lock(struct rte_eth_dev *dev, uint16_t _arg)			\
+{									\
+	struct mana_priv *priv = dev->data->dev_private;		\
+	int ret;							\
+	if (rte_spinlock_trylock(&priv->reset_ops_lock)) {		\
+		if (rte_atomic_load_explicit(&priv->dev_state,		\
+		    rte_memory_order_acquire) !=				\
+		    MANA_DEV_ACTIVE) {					\
+			rte_spinlock_unlock(&priv->reset_ops_lock);	\
+			return -EBUSY;					\
+		}							\
+		ret = _func(dev, _arg);					\
+		rte_spinlock_unlock(&priv->reset_ops_lock);		\
+	} else {							\
+		ret = -EBUSY;						\
+	}								\
+	return ret;							\
+}

CHECK:SPACING: No space is necessary after a cast
#1295: FILE: drivers/net/mana/mana.h:387:
+	RTE_ATOMIC(enum mana_device_state) dev_state;

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1429: FILE: drivers/net/mana/mp.c:220:
+				ret = mana_map_doorbell_secondary(

total: 0 errors, 1 warnings, 7 checks, 1530 lines checked
Warning in drivers/net/mana/mana.c:
Prefer rte_thread_(set_prefixed_name|create_internal_control)