|SUCCESS| buildtools/cmdline-gen: add more headers to generated file

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163505

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-30

Reviewing patch: buildtools/cmdline-gen: add more headers to generated file

git sha: 20260430113053.2397113-1-bruce.richardson at intel.com
Author: Bruce Richardson <bruce.richardson at intel.com>
Subject: [PATCH] buildtools/cmdline-gen: add more headers to generated file

This patch modifies the dpdk-cmdline-gen.py script to include additional
headers (stdint.h and cmdline_socket.h) in the generated header file to
improve usability for users of the generated code.

> diff --git a/buildtools/dpdk-cmdline-gen.py b/buildtools/dpdk-cmdline-gen.py
> index 7dadded783..d87adcfca9 100755
> --- a/buildtools/dpdk-cmdline-gen.py
> +++ b/buildtools/dpdk-cmdline-gen.py
> @@ -143,8 +143,11 @@ def process_commands(infile, hfile, cfile, ctxname):
>  /* File autogenerated by {sys.argv[0]} */
>  #ifndef GENERATED_COMMANDS_H
>  #define GENERATED_COMMANDS_H
> +

Is this blank line intentional? The coding style guide states that headers
should be grouped with no blank lines between system headers and library
headers. Does this code generate a blank line between the header guard and
the first include, or between groups of includes?

> +#include <stdint.h>
>  #include <rte_common.h>
>  #include <cmdline.h>
> +#include <cmdline_socket.h>
>  #include <cmdline_parse_string.h>
>  #include <cmdline_parse_num.h>
>  #include <cmdline_parse_ipaddr.h>

The header include ordering appears inconsistent with the coding style
guide. According to the guide, includes should be ordered: system headers
first, then library headers, with each group sorted alphabetically. Should
stdint.h be first as a system header, followed by the DPDK headers
alphabetically sorted (cmdline.h, cmdline_parse_ipaddr.h,
cmdline_parse_num.h, cmdline_parse_string.h, cmdline_socket.h,
rte_common.h)?

Does the generated code follow DPDK's include ordering conventions
elsewhere in the codebase?