|SUCCESS| cryptodev: update xform string array

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Thu Apr 30 22:11:12 CEST 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163506

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-04-30

Below is my plain text review for this patch:

---

Commit: bd3745e29065 (referenced in Fixes tag)
Author: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
Subject: [PATCH] cryptodev: update xform string array

This patch updates the crypto_asym_xform_strings[] array to include
string mappings for the ML-KEM and ML-DSA PQC algorithms that were
previously added to the enumeration but missing from the string array.

>  lib/cryptodev/rte_cryptodev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
> index 50071935c2..91f86c1590 100644
> --- a/lib/cryptodev/rte_cryptodev.c
> +++ b/lib/cryptodev/rte_cryptodev.c
> @@ -216,6 +216,8 @@ crypto_asym_xform_strings[] = {
>  	[RTE_CRYPTO_ASYM_XFORM_ECDSA]	= "ecdsa",
>  	[RTE_CRYPTO_ASYM_XFORM_ECPM]	= "ecpm",
>  	[RTE_CRYPTO_ASYM_XFORM_SM2]	= "sm2",
> +	[RTE_CRYPTO_ASYM_XFORM_ML_KEM]	= "ml-kem",
> +	[RTE_CRYPTO_ASYM_XFORM_ML_DSA]	= "ml-dsa",
>  };

Does this array require a sentinel or explicit size to prevent out of
bounds access? The original commit bd3745e29065 added these enum values
to rte_crypto_asym_xform_type, but without seeing the full array
definition, can the array indexing via these new enum values cause an
overflow if the array wasn't properly sized?

If crypto_asym_xform_strings[] is a fixed-size array rather than being
sized by the compiler from its initializers, does adding these entries
ensure the array size matches RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END or
the highest enum value?

The style and formatting look correct, matching the existing entries
with proper tab alignment.


More information about the test-report mailing list