|WARNING| [RFC,21/21] doc: add release not about rte_ethdev changes

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167112

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-02

# DPDK Patch Review

## Patch 01/21: net/dpaa, net/dpaa2: remove unused include

**No issues found.**

Removes unused `rte_eth_ctrl.h` include. Clean removal of deprecated header dependency.

---

## Patch 02/21: ethdev: use byte order instead of ntohl

**No issues found.**

Replaces `ntohl()` with DPDK's `rte_be_to_cpu_32()`. Correct migration away from system headers.

---

## Patch 03/21: net/ixgbe: remove experimental FDIR API

**Errors:**

1. **Missing release notes update.** This patch removes experimental public API (`rte_pmd_ixgbe_get_fdir_info`, `rte_pmd_ixgbe_get_fdir_stats`). Per guidelines (Documentation section), API changes must update release notes in the **current release** notes file. While the functions are experimental (no deprecation notice required for removal), the removal should still be documented for users.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_11.rst` under "Removed Items" noting the removal of these experimental FDIR functions.

---

## Patch 04/21: net/i40e: remove experimental FDIR API

**Errors:**

1. **Missing release notes update.** Same issue as patch 03/21. The patch removes experimental public API (`rte_pmd_i40e_get_fdir_info`, `rte_pmd_i40e_get_fdir_stats`) without updating release notes.

**Suggested fix:**
Add release notes entry documenting the removal.

---

## Patch 05/21: app/testpmd: remove support for flow director

**No issues found.**

Testpmd CLI is not a stable API. Removal does not require deprecation notice. The commit message correctly notes that the flow director API is deprecated and will be removed in 26.11.

---

## Patch 06/21: net/gve: include IP, UDP and TCP header

**No issues found.**

Adds direct includes for protocol headers to avoid implicit dependency on `rte_ethdev.h` inclusion chain.

---

## Patch 07/21: crypto/dpaa_sec: include UDP header

**No issues found.**

Same pattern as patch 06 -- adding missing direct includes.

---

## Patch 08/21: net/nfp: break implicit dependency on rte_eth_ctrl.h

**No issues found.**

Replaces use of `UINT64_BIT` (from deprecated header) with local `NFP_UINT64_BIT` definition. Clean workaround.

---

## Patch 09/21: net/mana: include used network headers

**No issues found.**

Adds missing includes for `rte_ip.h`, `rte_udp.h`, `rte_tcp.h`.

---

## Patch 10/21: gro: include headers directly

**No issues found.**

Adds `rte_vxlan.h` and protocol headers where used.

---

## Patch 11/21: test: include headers directly

**No issues found.**

Adds missing includes in test code.

---

## Patch 12/21: node: get UDP header

**No issues found.**

Adds `rte_udp.h` include.

---

## Patch 13/21: net/rnp: include network headers

**No issues found.**

Adds protocol header includes.

---

## Patch 14/21: net/r8169: get network headers

**No issues found.**

Adds protocol header includes.

---

## Patch 15/21: net/ngbe: include network protocol headers

**No issues found.**

Adds protocol header includes.

---

## Patch 16/21: examples: include network headers

**No issues found.**

Adds missing includes in example applications.

---

## Patch 17/21: net/mlx5: include rte_flow as needed

**No issues found.**

Adds `rte_flow.h` where used in mlx5 driver files.

---

## Patch 18/21: net/sfc: include rte_flow

**No issues found.**

Adds `rte_flow.h` include.

---

## Patch 19/21: net/intel: include network headers

**No issues found.**

Adds protocol header includes in Intel common code.

---

## Patch 20/21: ethdev, drivers: isolate flow director

**Errors:**

1. **`ethdev_fdir.h` should not be in `driver_sdk_headers`.** The new header `ethdev_fdir.h` is added to `driver_sdk_headers` in `lib/ethdev/meson.build`. Per the guidelines and the file's own comment ("Do not use in new drivers"), this is legacy API that should not be advertised as part of the driver SDK. It should remain a regular installed header for backward compatibility only, not listed in `driver_sdk_headers`.

**Suggested fix:**
```diff
 driver_sdk_headers += files(
         'ethdev_driver.h',
-        'ethdev_fdir.h',
         'ethdev_pci.h',
```

2. **Missing release notes update.** The patch renames and moves `rte_eth_ctrl.h` to `ethdev_fdir.h` and removes it from the public API documentation index (`doc/api/doxy-api-index.md`). This is a visible API change (header file name change, removal from documentation) and should be noted in release notes under "API Changes."

**Suggested fix:**
Add an entry to release notes documenting the header rename and isolation.

---

## Patch 21/21: doc: add release note about rte_ethdev changes

**Errors:**

1. **Incomplete release notes.** The patch adds notes about the `rte_ethdev.h` include changes (correct), but based on the earlier patches, it should also document:
   - Removal of experimental FDIR functions from `rte_pmd_ixgbe.h` and `rte_pmd_i40e.h` (patches 03, 04)
   - Renaming/isolation of `rte_eth_ctrl.h` to `ethdev_fdir.h` (patch 20)

**Suggested fix:**
Update the "Removed Items" section to include the FDIR function removals (mentioned in current diff but should reference the actual functions), and add an "API Changes" entry for the `rte_eth_ctrl.h` -> `ethdev_fdir.h` move.

---

## Summary

**Errors (must fix):**
- **Patch 03:** Missing release notes for removed experimental API
- **Patch 04:** Missing release notes for removed experimental API
- **Patch 20:** `ethdev_fdir.h` incorrectly added to `driver_sdk_headers`; missing release notes for header rename
- **Patch 21:** Release notes incomplete (should cover FDIR removals and header rename)

**Warnings:** None.

**Info:** The series correctly addresses the goal of isolating legacy flow director code and removing implicit header dependencies. The core technical changes are sound.