|WARNING| [v1] dts: update configuration for performance test

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167206

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-05

# DPDK Patch Review

## Summary

This patch adds configuration flexibility to the DTS (DPDK Test Suite) single-core forward performance test. It introduces per-test delta tolerance, configurable traffic duration, test repetitions, and TRex core count.

## Findings

### **Errors**

None identified.

### **Warnings**

**1. Missing schema validation for new configuration fields**

The `Config` class adds `traffic_duration` and `test_repetitions` fields without defaults or validation. If these fields are omitted from the YAML configuration, the test will fail at runtime.

**Suggested fix:**
```python
class Config(BaseConfig):
    """Performance test metrics."""

    test_parameters: list[dict[str, int | float]] = [
        # ... existing entries ...
    ]
    traffic_duration: int = 5  # Default value
    test_repetitions: int = 5  # Default value
```

**2. Missing schema validation for `delta_tolerance` in test parameters**

Each test parameter dict now expects a `delta_tolerance` key, but there's no validation that it exists or is a valid float. If a user adds a test case without this field, the code will raise a `KeyError` at runtime.

**Suggested fix:** Add validation in `set_up_suite()` or use a dataclass/TypedDict for test parameters:
```python
def set_up_suite(self):
    """Set up the test suite."""
    self.test_parameters = self.config.test_parameters
    # Validate all test parameters have required keys
    for params in self.test_parameters:
        if "delta_tolerance" not in params:
            raise ValueError(f"Test parameter missing 'delta_tolerance': {params}")
    self.traffic_duration = self.config.traffic_duration
    self.test_repetitions = self.config.test_repetitions
```

**3. Documentation does not match code**

The docstring for `_transmit()` is incorrect and appears to be copy-pasted from another function:
```python
def _transmit(self, testpmd: TestPmd, frame_size: int, repetitions: int = 1) -> float:
    """Create a testpmd session with every rule in the given list, verify jump behavior.
```

**Suggested fix:**
```python
def _transmit(self, testpmd: TestPmd, frame_size: int, repetitions: int = 1) -> float:
    """Transmit packets and measure average Rx packet rate.
    
    Args:
        testpmd: TestPmd instance to use for packet forwarding.
        frame_size: Size of packets to transmit.
        repetitions: Number of test iterations to average.
    
    Returns:
        Average received Mpps across all repetitions.
    """
```

**4. TRex cores configuration lacks validation**

The new `cores` field in `TrexTrafficGeneratorConfig` has no validation (type annotation only, no bounds check). A user could set `cores: -1` or `cores: 0` which would cause runtime errors.

**Suggested fix:** Add validation in the Trex class or config schema:
```python
def __init__(self, tg_node: Node, config: TrexTrafficGeneratorConfig) -> None:
    super().__init__(tg_node=tg_node, config=config)
    self._tg_node_config = tg_node.config
    self._tg_config = config
    if config.cores <= 0:
        raise ValueError(f"TRex cores must be positive, got {config.cores}")
    self._tg_cores = config.cores
```

### **Info**

**1. Configuration example shows default value**

The example configuration comment `# cores: 10` matches the old hardcoded value. Consider adding a note explaining how to determine the appropriate core count for the user's system.

**2. Test parameter repetition in configuration**

All test cases have identical `expected_mpps: 1.00` and `delta_tolerance: 0.05` values. This suggests the defaults could be factored out to avoid repetition:

```python
test_parameters: list[dict[str, int | float]] = [
    {"frame_size": 64, "num_descriptors": 1024},
    {"frame_size": 128, "num_descriptors": 1024},
    # ...
]
default_expected_mpps: float = 1.00
default_delta_tolerance: float = 0.05
```

Then apply defaults where not specified. However, this is purely a style suggestion for reducing YAML verbosity.

---

## Correctness Review

-  No resource leaks identified
-  No use-after-free patterns
-  No race conditions (single-threaded test execution)
-  Error paths are handled appropriately
-  No buffer overflows or undefined behavior

## Style Compliance

-  Python code follows conventions
-  No forbidden tokens
-  Proper indentation and formatting
-  Docstring does not match function behavior (Warning #3)

## Process Compliance

-  Patch targets appropriate files
-  Configuration schema extended correctly
-  Missing input validation could cause runtime failures (Warnings #1, #2, #4)