|SUCCESS| raw/cnxk_bphy: fix missing doxygen comments
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Aug 7 12:42:05 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/167368
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-07
# DPDK Patch Review
## Summary
This patch adds missing Doxygen comments to fix documentation build failures in the cnxk_bphy raw driver. The changes are minimal and documentation-focused.
---
## Findings
### Errors
None.
### Warnings
None.
### Info
**1. Documentation completeness**
The patch adds documentation for two enums but leaves `enum cnxk_bphy_cgx_eth_link_mode` (lines 165-174) without a Doxygen comment. While not strictly required if the enum was already present and the build is now working, consider adding a comment for consistency:
```c
/** Available Ethernet link modes */
enum cnxk_bphy_cgx_eth_link_mode {
...
};
```
**2. Enum value documentation**
The added comments describe the enums but not their individual values. For `cnxk_bphy_cgx_eth_mode_cpri`, each value already has an inline comment (e.g., `/** 2.4G Lane Rate */`), which is good. For `cnxk_bphy_cgx_mode_group`, the values `CNXK_BPHY_CGX_MODE_GROUP_ETH` and any following values should also have inline Doxygen comments for completeness:
```c
/** Available mode groups */
enum cnxk_bphy_cgx_mode_group {
/** ETH group */
CNXK_BPHY_CGX_MODE_GROUP_ETH,
/** CPRI group */
CNXK_BPHY_CGX_MODE_GROUP_CPRI,
};
```
This is an informational suggestion for consistency with the existing inline comments in `cnxk_bphy_cgx_eth_mode_cpri`.
---
## Overall Assessment
The patch correctly addresses the immediate issue (missing Doxygen comments preventing doc build). No correctness bugs, style violations, or guideline issues were found. The suggestions above are optional improvements for documentation completeness and consistency.
More information about the test-report
mailing list