|WARNING| raw/cnxk_bphy: fix missing doxygen comments

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167368

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-07

# DPDK Patch Review

## Summary
Patch adds missing Doxygen comments to fix documentation build for cnxk_bphy raw driver. No correctness issues found. Two minor style improvements noted.

---

## Findings by Severity

### Errors
None.

### Warnings

**1. Documentation comment style does not match DPDK convention**

**Location:** `drivers/raw/cnxk_bphy/rte_pmd_bphy.h:177, 195`

The added comments use `/**` (Doxygen style) but are placed before enum declarations in a way that suggests they document the enum type itself, not its values. DPDK convention for enum type documentation is a multi-line comment above the enum keyword.

Current:
```c
/** Available CPRI modes */
enum cnxk_bphy_cgx_eth_mode_cpri {
```

Preferred DPDK style:
```c
/**
 * Available CPRI modes
 */
enum cnxk_bphy_cgx_eth_mode_cpri {
```

The single-line `/** ... */` form is acceptable but less common for type-level documentation. Multi-line form with period at end is more consistent with existing DPDK practice.

**2. Missing release notes entry**

**Location:** N/A (missing file)

The patch fixes a documentation build failure (Bugzilla 1962) that would be visible to users building API docs. This is a user-facing bug fix and should have a brief entry in the current release notes under "Fixed Issues" or "Resolved Bugs" section.

Suggested addition to `doc/guides/rel_notes/release_<version>.rst`:
```rst
* **Fixed cnxk_bphy driver API documentation build.**

  Added missing Doxygen comments to fix documentation generation
  for the cnxk_bphy raw driver.
```

### Info
None.

---

## Positive Observations
- Patch correctly identifies the root cause (missing Doxygen comments)
- Fixes are minimal and targeted
- Proper `Fixes:` tags and `Cc: stable at dpdk.org` included
- Doxygen INPUT path addition is correct
- Comments added are factually accurate

---

## Recommendation
**ACCEPT with minor changes**: The two warnings are style preferences, not correctness issues. The patch is functional as-is but would benefit from:
1. Converting to multi-line comment style for consistency
2. Adding a release notes entry

Neither issue is severe enough to block merging if maintainer accepts current style.