|WARNING| [v2] net/mlx5: fix uint16 underflow on Rx queue error path

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167413

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-09

# DPDK Patch Review

## Summary
This patch fixes a uint16 underflow issue in the error cleanup path of `mlx5_rxq_mempool_register()`. The fix is correct and addresses a real bug, but there is one additional correctness issue in the cleanup logic.

---

## Errors

### 1. Potential Memory Leak on Error Path
**File:** `drivers/net/mlx5/mlx5_trigger.c`  
**Function:** `mlx5_rxq_mempool_register()`

The error cleanup path only frees `null_mbuf` when `seg->mp == NULL`, but the forward path allocates `null_mbuf` unconditionally for all segments:

```c
/* Forward path (implicit from context): */
seg->null_mbuf = mlx5_malloc(...);  /* allocated for every segment */

/* Error path: */
if (seg->mp == NULL) {              /* only frees if mp is NULL */
    mlx5_free(seg->null_mbuf);
}
```

If a segment has `seg->mp != NULL` but already had its `null_mbuf` allocated before the error occurred, that memory will leak.

**Fix:** Remove the `if (seg->mp == NULL)` condition. The cleanup should free `null_mbuf` for all segments that were successfully initialized, regardless of whether `mp` is NULL:

```c
while (s > 0) {
	s--;
	seg = &rxq_ctrl->rxq.rxseg[s];
	mlx5_free(seg->null_mbuf);
	seg->null_mbuf = NULL;
}
```

`mlx5_free()` is safe to call on NULL pointers (it wraps `rte_free()` which handles NULL), so this is safe even if some segments did not allocate `null_mbuf`.

---

## Warnings

None.

---

## Info

### Positive: Underflow Fix is Correct
The change from `while (s-- > 0)` to `while (s > 0) { s--; ... }` correctly prevents uint16 underflow when `s` is 0. The original code would decrement 0 to 65535, causing the loop to iterate over invalid memory. Well done.

---

## Additional Notes

- **Release notes:** This is a bug fix targeting `stable at dpdk.org`, so release notes are not required per the guidelines.
- **Code style:** The indentation and formatting are correct.
- **Error path tracing:** Always verify that every resource allocated in the forward path has a corresponding cleanup action on every error path. In this case, the conditional free appears to be overly restrictive.