|WARNING| net/idpf: propagate PCI NUMA node to vport ethdev

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167443

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-11

# DPDK Patch Review

## Patch Summary
The patch fixes missing NUMA node propagation in the IDPF driver when creating vport ethdevs, ensuring correct NUMA affinity for memory allocations on multi-socket systems.

---

## Review Findings

### **Errors**
None found.

### **Warnings**
None found.

### **Info**

**1. Release notes update missing**

The patch fixes a correctness bug (wrong NUMA node assignments leading to cross-NUMA memory access) that affects applications running on multi-socket systems. This is a user-visible behavior change that should be documented in the release notes.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_XX.rst` under "Fixed Issues":

```rst
* **net/idpf: Fixed NUMA node assignment for vport ethdevs.**

  The IDPF driver now correctly propagates the PCI device NUMA node to vport
  ethdevs, ensuring NUMA-local memory allocation for mempools and queue descriptors
  on multi-socket systems. Previously, all vports incorrectly reported socket ID 0.
```

Note: The `Cc: stable at dpdk.org` tag is correctly present for backporting to stable releases.

---

## Analysis

**Code correctness:** The fix is correct. The parent PCI device's NUMA node is properly propagated to the ethdev before any memory allocation occurs (the assignment happens early in `idpf_dev_vport_init()`).

**No resource leaks:** The added line is a simple integer assignment with no resource allocation.

**Style compliance:** The code follows DPDK style (single assignment statement, proper indentation).

**Impact:** This fixes real-world performance degradation on NUMA systems where the driver was previously allocating from socket 0 regardless of actual device location.

---

## Summary
The patch is correct and well-targeted. Only the release notes update is recommended to document this user-visible fix.