|WARNING| net/idpf: propagate PCI NUMA node to vport ethdev

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167443

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-11

# Review of DPDK Patch: net/idpf NUMA node propagation

## Summary
This patch fixes a NUMA affinity issue in the IDPF driver where vport ethdevs created via `rte_eth_dev_create()` do not inherit the parent PCI device's NUMA node. The fix is correct and follows the DPDK pattern used by other drivers in similar situations.

---

## Correctness Review

**No correctness bugs found.**

The patch is a simple one-line assignment that correctly propagates NUMA node information from the parent device to the ethdev data structure. This matches the pattern used in other DPDK drivers and resolves the reported issue.

---

## Code Style Review

**No style issues found.**

The added line follows DPDK coding standards:
- Proper indentation
- Correct variable access pattern
- Consistent with surrounding code

---

## API and Documentation Review

### Warning: Missing Release Notes

**Severity: Warning**

**Issue:** The patch fixes a significant functional bug (incorrect NUMA node assignment causing suboptimal memory allocation on multi-socket systems) but does not update the release notes.

**Why it matters:** Users need to be informed of this fix, especially those running DPDK on multi-socket systems where NUMA affinity directly impacts performance.

**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_26_11.rst` (or the appropriate current release notes file) in the "Fixed Issues" section:

```rst
* **net/idpf: Fixed NUMA node assignment for vport ethdevs.**

  The IDPF driver now correctly propagates the parent PCI device's NUMA node
  to vport ethdevs, ensuring proper NUMA-aware memory allocation on multi-socket
  systems. Previously, all vports reported NUMA node 0 regardless of actual
  device location.
```

---

## Process Review

### Info: Cc: stable@ is appropriate

The patch correctly includes `Cc: stable at dpdk.org` as this is a bug fix that should be backported to stable releases. The `Fixes:` tag correctly identifies the commit that introduced the issue.

---

## Final Assessment

**Overall:** The code change is correct and minimal. The only issue is the missing release notes entry, which should be added to inform users of this important fix.

**Recommendation:** Approve with the suggestion to add release notes in a v2.