|WARNING| crypto/ipsec_mb: require minimum version 2.0 for IPsec MB

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167478

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-11

# DPDK Patch Review

## Summary

This patch increases the minimum required Intel IPsec MB library version from 1.4 to 2.0 for the ipsec_mb crypto PMD and removes conditional compilation for features that are now always available. The patch is clean with no correctness bugs identified. Minor documentation improvements are suggested.

---

## Warnings

### Documentation

**File: `doc/guides/cryptodevs/aesni_gcm.rst`, Line 43**

URL formatting inconsistency: The updated URL uses angle brackets while the ARM library URL (line 46-47) does not. For consistency, prefer one style throughout.

Suggested fix:
```rst
can be downloaded from https://github.com/01org/intel-ipsec-mb/archive/v2.0.zip.
```
or keep the angle brackets but apply consistently to all URLs.

---

**File: `doc/guides/cryptodevs/aesni_mb.rst`, Line 99**

Same URL formatting inconsistency as above.

---

**File: `doc/guides/rel_notes/release_26_11.rst`, Lines 62-64**

Release note formatting: The heading "Updated AESNI_MB crypto driver" is misleading -- this is a removal/breaking change (increasing minimum library version), not a feature update. Consider moving this to a "Breaking Changes" or "Removed Items" section instead of framing it as an update.

Suggested alternative:
```rst
* **Increased minimum IPsec MB library version for ipsec_mb PMD.**

  The ipsec_mb crypto driver now requires IPsec MB library version 2.0 or newer.
  Support for versions 1.4-1.5 has been removed.
```

---

**File: Multiple documentation files**

The version compatibility tables now show overlapping ranges that may confuse readers:
```
24.11 - 26.07  Multi-buffer library 1.4  - 2.0
26.11+         Multi-buffer library 2.0+
```

The 26.07 release would support 1.4-2.0, but 26.11 requires 2.0+. This is correct but the transition point could be clearer. Consider adding a note:

```rst
.. note::
   DPDK 26.11 raises the minimum required version to 2.0.
   Earlier DPDK releases (24.11 through 26.07) support 1.4-2.0.
```

---

## Info

### Code Cleanup

**Files: `pmd_aesni_mb.c`, `pmd_aesni_mb_priv.h`**

The removal of `#if IMB_VERSION(...)` conditionals is correct and simplifies maintenance. All removed code blocks are for features introduced in library versions older than the new minimum (2.0), so the cleanup is safe.

The code now assumes:
- SM3 and SM3-HMAC support (added in 1.5.0)
- SM4-CTR and SM4-GCM support (added after 1.5.0)

This is appropriate given the new minimum version requirement.

---

### Meson Build Files

**Files: `drivers/common/qat/meson.build`, `drivers/crypto/ipsec_mb/meson.build`**

The version bump from `'1.4.0'` to `'2.0.0'` is consistent across both build files. The QAT driver comment removal (lines 41-42 in qat/meson.build) is acceptable as the code is self-documenting.

---

## No Issues Found

- No resource leaks or use-after-free bugs
- No race conditions or synchronization issues
- No forbidden tokens or deprecated API usage
- No alignment/packing attribute misuse
- No missing error checks on failure paths
- No ABI compatibility issues (this is a breaking change properly documented in release notes)
- Copyright/SPDX compliance not reviewed per guidelines
- All removed preprocessor conditionals guard code for features guaranteed present in v2.0+
- Code style compliant with DPDK standards

---

## Conclusion

The patch is functionally correct. The only suggestions are minor documentation improvements for clarity and consistency. The code changes properly reflect the new minimum library version by removing now-unnecessary conditional compilation.