|WARNING| [2/2] net/i40e: program default RSS RETA at port configure

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167572

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-12

# DPDK Patch Review

## PATCH 1/2: net/i40e: preserve RSS RETA across port stop and start

### Errors

None identified.

### Warnings

None identified.

### Info

None identified.

---

## PATCH 2/2: net/i40e: program default RSS RETA at port configure

### Errors

**Missing error path cleanup:**

In `i40e_dev_configure()`, the new call to `i40e_pf_reset_rss_reta(pf)` returns an error code but does not jump to the existing `err:` cleanup label on failure. Instead, it returns directly, bypassing any cleanup that should occur after the earlier successful operations in the function (such as RSS offload setup).

```c
/* Current code - returns directly on error */
ret = i40e_pf_reset_rss_reta(pf);
if (ret)
	return ret;

/* Should be - jump to cleanup on error */
ret = i40e_pf_reset_rss_reta(pf);
if (ret)
	goto err;
```

Without seeing the full function context, I cannot verify what cleanup is needed, but the existing pattern in this function uses `goto err;` for error paths after early setup steps, and this new error path should follow the same pattern for consistency and correctness.

### Warnings

None identified.

### Info

None identified.

---

## Summary

**Patch 1/2:** No issues found. The fix correctly moves the `rss_reta_updated` flag reset from `i40e_dev_stop()` to `i40e_dev_configure()`, preserving user RETA configuration across stop/start while still resetting it on reconfiguration.

**Patch 2/2:** One error identified - missing jump to error cleanup label when `i40e_pf_reset_rss_reta()` fails. The direct return should be changed to `goto err;` to ensure proper cleanup of any resources initialized earlier in `i40e_dev_configure()`.