|WARNING| [v2, 14/14] app/procinfo: use common division round up macro

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167722

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-13

# DPDK Patch Review

## Patch Series Summary
This patch series introduces a new macro `RTE_DIV_ROUND_UP` to `rte_common.h` and replaces driver-local `DIV_ROUND_UP` definitions throughout the codebase. I reviewed all 14 patches focusing on correctness, style, and API requirements.

---

## Patch 01/14: eal: introduce division round up macro

**Errors:**

None.

**Warnings:**

1. **Macro lacks input validation documentation** (Warning):
   The Doxygen comment does not specify the valid input ranges or warn about potential overflow.
   When `n + (d) - 1` overflows (e.g., if `n` is close to `UINT32_MAX` or `UINT64_MAX`), the result is wrong.
   Suggest adding a note:
   ```c
   /**
    * Macro to divide dividend n by divisor d, rounding up if d does not divide n.
    * @note Ensure n + d - 1 does not overflow the type of n.
    */
   ```

---

## Patches 02-14: Driver replacements

I checked all driver patches (02/14 through 14/14) that replace local `DIV_ROUND_UP` definitions with `RTE_DIV_ROUND_UP`. These patches are mechanical substitutions with no logic changes.

**Errors:**

None across patches 02-14.

**Warnings:**

None. All replacements are straightforward and preserve existing behavior.

---

## Summary

**Total Findings:**
- **Errors:** 0
- **Warnings:** 1 (documentation improvement for overflow behavior in patch 01/14)

The patch series is well-structured. The only suggestion is to improve the documentation of `RTE_DIV_ROUND_UP` to alert users about potential overflow when `n` is near the maximum value of its type. This is a common pitfall with this pattern and worth documenting.

All driver replacements are correct and consistent with DPDK coding standards.