|WARNING| eal/linux: harden uevent recv error handling

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167740

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-14

# DPDK Patch Review

## Patch: eal/linux: harden uevent recv error handling

---

## ERRORS

### 1. Spelling error in log message (Error)

**Location:** Line 249
```c
EAL_LOG(ERR, "unexpected error on uvent recv: %d", errno);
```

**Issue:** "uvent" should be "uevent"

**Fix:**
```c
EAL_LOG(ERR, "unexpected error on uevent recv: %d", errno);
```

---

### 2. Missing conditional braces (Error)

**Location:** Lines 244-245, 247-250

**Issue:** Multi-line conditional bodies must use braces per DPDK coding style.

**Current code:**
```c
if (ret < 0 &&
	(errno == EAGAIN || errno == EWOULDBLOCK))
	return;
else if (ret < 0 &&
	 (errno == ENOBUFS || errno == ENOMEM)) {
```

**Fix:**
```c
if (ret < 0 &&
		(errno == EAGAIN || errno == EWOULDBLOCK)) {
	return;
} else if (ret < 0 &&
		(errno == ENOBUFS || errno == ENOMEM)) {
```

---

### 3. Incorrect continuation indentation (Error)

**Location:** Line 245, 248

**Issue:** Continuation lines should be double-indented (two tabs) per DPDK style. Currently using single tab + spaces.

**Current code:**
```c
if (ret < 0 &&
	(errno == EAGAIN || errno == EWOULDBLOCK))
	return;
else if (ret < 0 &&
	 (errno == ENOBUFS || errno == ENOMEM)) {
```

**Fix:**
```c
if (ret < 0 &&
		(errno == EAGAIN || errno == EWOULDBLOCK)) {
	return;
} else if (ret < 0 &&
		(errno == ENOBUFS || errno == ENOMEM)) {
```

---

### 4. Brace placement for else-if (Error)

**Location:** Lines 246-247

**Issue:** Braces should be on same line as `else if`, not starting a new block after the condition.

**Current code:**
```c
	return;
else if (ret < 0 &&
	 (errno == ENOBUFS || errno == ENOMEM)) {
```

**Fix:**
```c
	return;
} else if (ret < 0 &&
		(errno == ENOBUFS || errno == ENOMEM)) {
```

---

## WARNINGS

### 1. Incomplete error handling justification (Warning)

**Issue:** The patch adds handling for `ENOBUFS` and `ENOMEM` but only logs them and returns, treating them the same as `EAGAIN`/`EWOULDBLOCK`. These are different error classes:
- `EAGAIN`/`EWOULDBLOCK`: temporary condition, retry is appropriate
- `ENOBUFS`/`ENOMEM`: resource exhaustion, may indicate system-wide issues

**Suggestion:** Consider whether these errors should be handled differently, or add a comment explaining why logging and continuing is the appropriate behavior.

---

### 2. Log message improvement (Info)

**Current:**
```c
EAL_LOG(ERR, "unexpected error on uevent recv: %d", errno);
```

**Suggestion:** Use `%s` with `strerror(errno)` for more informative error messages:
```c
EAL_LOG(ERR, "unexpected error on uevent recv: %d (%s)", 
        errno, strerror(errno));
```

This follows the pattern used in the existing error message at line 253.

---

## SUMMARY

The patch adds error handling for additional errno values (`EWOULDBLOCK`, `ENOBUFS`, `ENOMEM`) to the uevent receive path, which improves robustness. However, it has several coding style violations that must be fixed:

1. **Typo** in error message ("uvent" - "uevent")
2. **Missing braces** on multi-line if statements
3. **Incorrect indentation** of continuation lines (should be double-indented)
4. **Brace placement** for else-if blocks

The error handling logic itself appears correct but could benefit from clearer justification of why `ENOBUFS`/`ENOMEM` are treated as non-fatal.