|WARNING| [v2] crypto/ipsec_mb: require minimum version 2.0 for IPsec MB

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167868

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-17

# DPDK Patch Review

## Patch: crypto/ipsec_mb: require minimum version 2.0 for IPsec MB

### Summary
This patch updates the minimum required Intel IPsec Multi-Buffer library version from 1.4.0 to 2.0.0 for x86 platforms and removes preprocessor conditionals for features that are now unconditionally available.

---

## ERRORS

None identified.

---

## WARNINGS

### 1. Release notes placement (Warning)
**Location:** `doc/guides/rel_notes/release_26_11.rst`

The release note is placed under "Removed Items" section, but the change is more accurately a dependency version update rather than a feature removal.

**Suggested fix:**
Consider moving to a more appropriate section or creating an "Updated Libraries" section. The current placement is acceptable but could be improved for clarity:

```rst
API Changes
-----------

* **crypto/ipsec_mb: Increased minimum IPsec MB library version.**

  The minimum required version of Intel IPsec Multi-Buffer library
  for x86 platforms has been increased from 1.4.0 to 2.0.0.
  Support for older versions has been removed.
```

### 2. Inconsistent documentation update (Warning)
**Location:** `doc/guides/cryptodevs/qat.rst`, line 363

The QAT documentation states `Intel IPsec MB library (v2.0+)` while aesni_mb and aesni_gcm docs say `v2.0`. Consider consistent formatting: either `v2.0` or `v2.0+` across all three files.

**Suggested fix:**
Use `v2.0+` consistently to indicate "version 2.0 or later":

```rst
The latest version of the library supported by this PMD is v2.0+, which
can be downloaded from ...
```

---

## INFO

### 1. Code cleanup verification (Info)
The removal of all `#if IMB_VERSION(1, 5, 0)` conditionals is correct and consistent with the version bump to 2.0. All features previously conditional on version checks are now unconditionally available:

- SM3/SM3_HMAC authentication
- SM4_CBC, SM4_ECB, SM4_CTR ciphers  
- SM4_GCM AEAD

The cleanup correctly removes:
- Version check preprocessor guards
- Associated code in capabilities tables
- Version-dependent key expansion and job parameter handling

### 2. ARM platform handling (Info)
The patch correctly preserves the older 1.4.0 requirement for ARM platforms by setting `IMB_required_ver = '1.4.0'` when `arch_subdir == 'arm'` in `drivers/crypto/ipsec_mb/meson.build`. This is appropriate since ARM uses a different IPsec-MB implementation.

### 3. Documentation version matrix updates (Info)
The version compatibility matrices in both aesni_mb.rst and aesni_gcm.rst have been correctly updated to show:
- Historical support (20.11 through 26.07)
- New minimum requirement (26.11+: v2.0+)

---

## CONCLUSION

The patch is correct and implements the stated goal of raising the minimum IPsec-MB version requirement. The code cleanup properly removes all version-conditional code that is no longer needed. The two warnings are minor documentation consistency issues that do not affect correctness.