|WARNING| [v2] crypto/ipsec_mb: require minimum version 2.0 for IPsec MB

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167868

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-17

# DPDK Patch Review

## Patch Summary
This patch updates the minimum required Intel IPsec MB library version from 1.4.0 to 2.0.0 for x86 platforms and removes version-gated code that checked for older library versions.

---

## Errors

### 1. Memory ordering for shared variables (pmd_aesni_mb.c)

If `mb_mgr` is shared between threads or accessible across multiple cores, any accesses to shared state within the `IMB_MGR` structure should use atomic operations with appropriate memory ordering instead of plain loads/stores. While this patch doesn't add new shared accesses, review whether existing uses of `mb_mgr` in functions like `aesni_mb_set_session_cipher_parameters()` and `set_mb_job_params()` properly synchronize if the manager can be accessed concurrently.

**Note:** This is flagged as a potential issue to verify. If `mb_mgr` is per-queue and never shared, this is not an error. If it is shared, verify that accesses use appropriate synchronization.

---

## Warnings

### 1. Release notes placement (release_26_11.rst)

The removal of support for IPsec MB versions older than 2.0 is documented under "Removed Items" but should also be mentioned under "New Features" or a dedicated section describing the library version requirement change, as this is a significant compatibility change that affects users.

**Suggested fix:**
Add an entry under "New Features" or create an "Updated Items" section:
```rst
* **Updated IPsec MB crypto drivers.**

  * Increased minimum required IPsec MB library version to 2.0.0 for x86 platforms.
  * ARM platforms continue to support library version 1.4.0+.
```

### 2. Documentation version table formatting (aesni_mb.rst)

The version compatibility table has inconsistent spacing in the version ranges. The "24.11 - 26.07" entry uses different spacing than the others.

**Current:**
```rst
24.11 - 26.07   1.4  - 2.0
26.11+          2.0+
```

**Suggested (for consistency):**
```rst
24.11 - 26.07   1.4 - 2.0
26.11+          2.0+
```

### 3. Missing functional test coverage verification

The patch removes significant conditional compilation blocks (SM3, SM4 cipher modes) that were previously gated on `IMB_VERSION` checks. Verify that functional tests exist for:
- SM3 and SM3-HMAC authentication
- SM4-CBC, SM4-ECB, SM4-CTR ciphers  
- SM4-GCM AEAD

If tests don't exist or weren't previously run due to version constraints, they should be added or verified to run with the new minimum library version.

---

## Info

### 1. Consistent comment style

In `pmd_aesni_mb.c`, removed `#if IMB_VERSION` blocks leave some inconsistent comment spacing. Consider normalizing comment placement around the newly unconditional SM4-GCM and SM3 cases for better readability.

**Example (line ~1055):**
```c
	case IMB_AUTH_CHACHA20_POLY1305.aad = aad->va;
		break;


	case IMB_AUTH_SM4_GCM:
		job->u.GCM.aad = aad->va;
		break;

```

The extra blank line before `case IMB_AUTH_SM4_GCM` is inconsistent with the style of other case blocks. Consider removing it for consistency.

### 2. ARM platform exception clarity

The meson.build change for ARM platforms (preserving 1.4.0 requirement) is correct, but consider adding a comment explaining why ARM has a different requirement:

```python
if arch_subdir == 'arm'
    IMB_header = '#include<ipsec-mb.h>'
    # ARM uses ARM64 port which maintains backward compatibility
    IMB_required_ver = '1.4.0'
endif
```

---

## Summary

**Critical issues:** 0  
**Warnings:** 3  
**Info items:** 2

The patch correctly removes version-gated code now that the minimum version guarantees those features are always present. The main concerns are:
1. Verification that `mb_mgr` accesses are properly synchronized if shared across threads
2. Ensuring release notes adequately communicate the breaking change
3. Verifying test coverage for newly-unconditional features (SM3, SM4)

The code changes themselves are mechanically correct - they simply remove preprocessor guards around features that are now guaranteed to be available.