|WARNING| [v2] eal/linux: harden uevent recv error handling

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167876

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-17

# DPDK Patch Review: eal/linux: harden uevent recv error handling

## Summary
This patch improves error handling in the Linux uevent receiver by handling additional error conditions (EWOULDBLOCK, EINTR, ENOBUFS) that can occur during device hotplug operations.

---

## Errors

### 1. Missing `errno` before `EINTR` in conditional
**Line:** `if (ret < 0 && (errno == EAGAIN || errno == EWOULDBLOCK || EINTR))`

The third condition `EINTR` is missing the `errno ==` prefix, causing it to be evaluated as a non-zero constant (always true). This makes the entire compound condition always true when `ret < 0`, causing the function to return early for all errors instead of just the intended non-blocking/interrupt cases.

**Fix:**
```c
if (ret < 0 &&
    (errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR)) {
```

---

## Warnings

### 1. Inconsistent parenthesis style
The first error condition check uses `(errno == EAGAIN || errno == EWOULDBLOCK || EINTR)` with the entire set of errno comparisons grouped in parentheses, while the second uses `(errno == ENOBUFS)` with parentheses around a single comparison. The outer parentheses in `(errno == ENOBUFS)` are unnecessary.

**Suggested fix:**
```c
} else if (ret < 0 && errno == ENOBUFS) {
```

This makes the style consistent with typical C conditional patterns and matches the compound style used in the first condition.

### 2. `ENOBUFS` handling logs error but continues silently
The comment says "non-fatal transient memory condition" but the log level is `ERR`, which is typically used for serious errors. For a condition that the code considers non-fatal and recoverable (it returns and allows retry), `WARNING` or `NOTICE` would be more appropriate.

**Suggested fix:**
```c
	} else if (ret < 0 && errno == ENOBUFS) {
		/* non-fatal transient memory condition */
		EAL_LOG(WARNING, "uevent recv encountered transient memory pressure: %s",
			strerror(errno));
		return;
```

---

## Info

### 1. POSIX errno values already covered
According to POSIX, for non-blocking sockets, both `EAGAIN` and `EWOULDBLOCK` may be returned when no data is available, and they often have the same value on Linux. Explicitly checking both is defensive but redundant on most systems. However, this is acceptable defensive programming for portability.

### 2. Comment clarity
The comment "non-blocking or interrupted" is accurate but could be more precise about what action is being taken:
```c
	/* Would block or interrupted - retry on next callback invocation */
```

---

## Final Check Results

**Correctness bugs found:** 1 (missing `errno ==` before `EINTR`)  
**Style issues:** 2 (unnecessary parentheses, log level mismatch with severity)  
**Process/API issues:** None

The critical bug (missing `errno ==`) makes the condition always true for any error, completely changing the control flow. This must be fixed.