|WARNING| [v3] eal/linux: harden uevent recv error handling

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167878

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-17

# DPDK Patch Review

## Patch: eal/linux: harden uevent recv error handling

---

## Errors

### 1. Logic error in conditional - missing `errno ==` before `EINTR`

**Location:** `lib/eal/linux/eal_dev.c:245`

```c
if (ret < 0 &&
    (errno == EAGAIN || errno == EWOULDBLOCK || EINTR)) {
```

The condition `|| EINTR` evaluates `EINTR` as a boolean (non-zero = true), making it always true. This causes ALL errors to be treated as non-blocking/interrupted and silently ignored, including fatal errors like `EBADF` or `ECONNRESET`.

**Fix:**
```c
if (ret < 0 &&
    (errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR)) {
```

---

## Warnings

### 1. Inconsistent errno comparison - missing parentheses

**Location:** `lib/eal/linux/eal_dev.c:248`

```c
} else if (ret < 0 && (errno == ENOBUFS)) {
```

The parentheses around `errno == ENOBUFS` are unnecessary and inconsistent with the preceding condition style. While not technically wrong, consistency improves readability.

**Suggestion:** Remove unnecessary parentheses:
```c
} else if (ret < 0 && errno == ENOBUFS) {
```

### 2. Non-inclusive terminology in comment

**Location:** `lib/eal/linux/eal_dev.c:269`

```c
/* connection is closed or broken, can not up again. */
```

The phrase "can not up again" is unclear English. Should be "cannot recover" or "cannot be restored".

**Suggestion:**
```c
/* Connection is closed or broken and cannot be restored. */
```

---

## Info

### 1. Log level mismatch for non-fatal error

**Location:** `lib/eal/linux/eal_dev.c:250-251`

```c
EAL_LOG(ERR, "unexpected error on uevent recv: %s",
    strerror(errno));
```

The code treats `ENOBUFS` as "non-fatal transient" but logs at `ERR` level. This may cause alarm in production logs for a condition the code considers recoverable. Consider `WARNING` level instead:

```c
EAL_LOG(WARNING, "Transient uevent recv error: %s",
    strerror(errno));
```

### 2. Comment capitalization and punctuation

Comments should be complete sentences with proper capitalization and ending punctuation:

```c
/* Non-blocking or interrupted */
/* Non-fatal transient memory condition */
```

---

## Summary

**Critical fix required:** The missing `errno ==` before `EINTR` is a correctness bug that breaks error handling for all error cases, causing the function to silently ignore fatal errors. This must be fixed.

The other items are style/clarity improvements that enhance code quality but are not correctness issues.