|WARNING| app/test: lpm6 perf autotest fix lpm delete total time
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Wed Aug 19 04:46:20 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/167974
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-19
# DPDK Patch Review
## Summary
This patch fixes a statistics accumulation bug in the LPM6 performance test where `total_time` was incorrectly using `+=` instead of `=` for measuring deletion time, causing cumulative timing from previous test phases to corrupt the delete-only measurement.
---
## Errors
**None**
---
## Warnings
**None**
---
## Info
### Correctness - Statistics Bug Fix (Positive Finding)
The patch correctly identifies and fixes a statistics accumulation error:
**Before:**
```c
total_time += rte_rdtsc() - begin;
```
**After:**
```c
total_time = rte_rdtsc() - begin;
```
**Why this is correct:**
Looking at the test structure in `test_lpm6_perf.c`:
1. Earlier phases use `total_time += ...` to accumulate route addition times over multiple iterations
2. The delete phase measures a separate operation and should report *only* deletion time
3. Using `+=` here incorrectly adds the deletion time to the accumulated insertion time from earlier in the test
4. This produces a wrong "Average LPM Delete" measurement that includes insertion overhead
The fix properly isolates the delete timing measurement.
### .mailmap Entry
The `.mailmap` entry is correctly formatted and maps the contributor's personal and work email addresses.
---
## Conclusion
This is a clean bug fix with no issues identified. The patch addresses a real correctness bug in test statistics reporting without introducing new problems.
More information about the test-report
mailing list