|WARNING| net/ice/base: add missing devices to supported products

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168020

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-19

# Review of DPDK Patch: net/ice/base: add missing devices to supported products

## Summary

This patch updates the README file for the ice base driver to document additional supported Intel Ethernet controller models. The patch is **documentation-only** and adds no code changes.

---

## Correctness

**No issues found.** This is a documentation-only patch that adds no code.

---

## C Coding Style

**Not applicable.** No C code is modified.

---

## API and Documentation Requirements

### Missing Release Notes (Warning)

The patch adds significant product documentation (support for E822, E823, E825, E835 controllers) but does not update the release notes in `doc/guides/rel_notes/`.

**Issue:** New driver capabilities or supported products should be documented in the current release notes file (likely `doc/guides/rel_notes/release_26_11.rst` or similar based on the 2026 date).

**Suggested fix:** Add a section to the release notes:

```rst
* **Updated ice base driver documentation.**

  Added E822, E823, E825, and E835 controller models to the list of
  supported products in the ice base driver README.
```

**Note:** If these controllers were already supported in prior releases and this is merely correcting outdated documentation, then release notes are not required. However, the commit message does not indicate this is a documentation correction vs. announcing new support.

---

## Documentation Style

### HTTP URL (Error)

The patch itself does not modify URLs, but for completeness: if any URLs to `dpdk.org` exist elsewhere in the document, they should use `https://` not `http://`. This patch does not introduce such URLs.

**No issues in this patch.**

---

## Other Observations (Info)

1. **README location:** The file is under `drivers/net/intel/ice/base/README`, which is in a base driver directory. Per the guidelines, base directories may use different conventions from the rest of DPDK. This README appears to be vendor-provided documentation.

2. **Alphabetical ordering:** The updated list maintains alphabetical order of model numbers except E830 appears between E825 and E835. However, this appears to be an intentional grouping (E8x0 series separate from E8x2/E8x3/E8x5 series), which is acceptable.

3. **No Cc: stable at dpdk.org:** This is not a bug fix, so `Cc: stable at dpdk.org` is not required.

---

## Final Assessment

**Warnings:**
- Missing release notes update for new/corrected product documentation

**Errors:**
None

**Overall:** The patch is acceptable if release notes are added (or if this is documented as a correction to existing capabilities). The documentation-only nature means there are no correctness concerns.