|WARNING| pw168113 [PATCH v1 14/21] net/i40e: reimplement FDIR parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/168113

_coding style issues_


WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#2598: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:45:
+ * Pattern: START -> ETH -> [VLAN] -> (IPv4 | IPv6) -> [TCP | UDP | SCTP | ESP | L2TPv3 | GTP] -> END

WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#3032: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:479:
+		memcpy(&filter->input.flow.ipv6_flow.src_ip, &ipv6_spec->hdr.src_addr, sizeof(ipv6_spec->hdr.src_addr));

WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#3036: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:483:
+		memcpy(&filter->input.flow.ipv6_flow.dst_ip, &ipv6_spec->hdr.dst_addr, sizeof(ipv6_spec->hdr.dst_addr));

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3055: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:502:
+	if (ipv6_spec->hdr.proto == I40E_IPV6_FRAG_HEADER) {
+		filter->input.pctype = I40E_FILTER_PCTYPE_FRAG_IPV6;
+	}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3118: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:565:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3205: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:652:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3296: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:743:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3305: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:752:
+	if (!CI_FIELD_IS_ZERO(&sctp_mask->hdr.tag)) {
+		filter->input.flow_ext.input_set |= I40E_INSET_SCTP_VT;
+	}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3578: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1025:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#3580: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1027:
+		else {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3584: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1031:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#3586: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1033:
+		else {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#3608: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1055:
+
+}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3624: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1071:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4143: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1590:
+	if (ret) {
+		return ret;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4148: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1595:
+	if (ret) {
+		return ret;
+	}

total: 0 errors, 13 warnings, 3 checks, 4250 lines checked