|WARNING| pw168109 [PATCH v1 10/21] net/ixgbe: reimplement FDIR parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/168109

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#2348: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:564:
+^I^I^I               RTE_FLOW_NODE_EXPECT_SPEC_MASK,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2378: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:594:
+^I^I^I               RTE_FLOW_NODE_EXPECT_MASK |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2379: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:595:
+^I^I^I               RTE_FLOW_NODE_EXPECT_SPEC_MASK,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2387: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:603:
+^I^I^I               RTE_FLOW_NODE_EXPECT_MASK |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2388: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:604:
+^I^I^I               RTE_FLOW_NODE_EXPECT_SPEC_MASK,$

WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns
#2490: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:706:
+ * Pattern: START -> [OUTER_ETH] -> (OUTER_IPv4|OUTER_IPv6) -> [UDP] -> (VXLAN|NVGRE) -> INNER_ETH -> [VLAN] -> END

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#2491: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:707:
+ * VxLAN:  START -> [OUTER_ETH] -> (OUTER_IPv4|OUTER_IPv6) -> UDP -> VXLAN -> INNER_ETH -> [VLAN] -> END

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2690: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:906:
+		if (eth_mask->hdr.dst_addr.addr_bytes[j] == 0xFF) {
+			rule->mask.mac_addr_byte_mask |= 0x1 << j;
+		}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE'
#2958: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1174:
+	if ((fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE) &&
+	    (fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP'
#2958: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1174:
+	if ((fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE) &&
+	    (fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP)) {

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#3028: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1244:
+	if (fdir_ctx->aux_action != NULL && fdir_ctx->aux_action->type == RTE_FLOW_ACTION_TYPE_MARK) {

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#3150: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1366:
+	struct ixgbe_adapter *adapter = IXGBE_DEV_PRIVATE_TO_ADAPTER(fdir_flow->flow.flow.dev_data->dev_private);

total: 5 errors, 5 warnings, 2 checks, 3228 lines checked