|WARNING| [v2,2/2] net/i40e: move mutable fields out of RSS config

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168168

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-21

# DPDK Patch Review

## Patch 1/2: net/i40e: do not use flow RSS conf struct

### Errors

None identified.

### Warnings

None identified.

### Info

This patch refactors the RSS filter structure to avoid storing `struct rte_flow_action_rss` directly, eliminating pointer lifetime issues. The implementation is sound:

1. Direct member fields replace the embedded struct
2. All users correctly updated to populate fields individually
3. The `i40e_flow_query()` function properly reconstructs the `rte_flow_action_rss` on the fly with correct pointer handling (NULL when length is zero)
4. Key and queue arrays are copied into the filter structure (avoiding dangling pointers)

---

## Patch 2/2: net/i40e: move mutable fields out of RSS config

### Errors

None identified.

### Warnings

None identified.

### Info

This patch cleanly separates RSS configuration data (received from rte_flow API) from internal metadata (reset flags, pctype tracking). The separation improves code clarity:

1. New `i40e_rss_filter_data` structure holds metadata
2. All functions correctly updated to access both structures
3. The `i40e_hash_config()` signature change properly reflects that it operates on the entire filter (both config and metadata)
4. Filter invalidation logic (`i40e_invalid_rss_filter()`) correctly operates on the separate structures

---

## Overall Assessment

Both patches are well-structured refactoring changes that improve code maintainability by:
- Eliminating embedded structures with pointers (reduces lifetime bugs)
- Separating concerns (API data vs internal metadata)
- Maintaining correct behavior through all code paths

**No correctness bugs, style violations, or guideline issues identified.**

The patches are ready for acceptance pending standard checkpatch/build validation.