|WARNING| [4/4] net/qede: remove unused app version variable

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168386

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-27

# DPDK Patch Review

## Patch 1/4: common/dpaax: fix unused variable warning in non-debug build

### No Issues Found

The patch correctly addresses an unused variable warning by making the macro consume its argument even in non-debug builds. The use of `RTE_SET_USED(cond)` is the standard DPDK pattern for this situation.

---

## Patch 2/4: bus/dpaa: remove unused device counter

### No Issues Found

The patch correctly removes dead code - a variable that was written but never read. The removal is clean with no impact on correctness.

---

## Patch 3/4: common/zsda: remove unused device counter

### Errors

**Resource leak on error path after counter removal**

In `zsda_pci_device_allocate()`, when `rte_memzone_reserve()` fails, the function returns NULL without cleaning up the previously allocated `zsda_dev_id`. The removed counter decrement was masking this issue, but the underlying problem remains: `zsda_dev_id` is consumed (incremented) before the allocation that can fail, and there is no rollback if the allocation fails.

```c
/* Line ~98 in zsda_device.c - after the patch */
zsda_dev_id = zsda_find_free_device_index();
if (zsda_dev_id < 0)
    return NULL;

snprintf(name, RTE_MEM_NAMESIZE, "zsda_dev%d", zsda_dev_id);
mz = rte_memzone_reserve(name, sizeof(struct zsda_pci_device),
             rte_socket_id(), 0);
if (mz == NULL) {
    ZSDA_LOG(ERR, "Failed to allocate memzone for device");
    return NULL;  /* BUG: zsda_dev_id consumed but allocation failed */
}
```

**Suggested fix:** Mark the device index as free on memzone allocation failure:

```c
if (mz == NULL) {
    ZSDA_LOG(ERR, "Failed to allocate memzone for device");
    zsda_devs[zsda_dev_id].pci_dev = NULL;  /* Release the index */
    return NULL;
}
```

---

## Patch 4/4: net/qede: remove unused app version variable

### No Issues Found

The patch correctly removes dead code - a variable that was stored but never read. The validation logic in `qed_dbg_set_app_ver()` is preserved, so the function's error-checking behavior remains intact.

---

## Summary

**Patches 1, 2, and 4:** Clean dead code removal, no issues.

**Patch 3:** Exposes a pre-existing resource leak (device index consumed but not released on allocation failure). While the patch itself does not introduce the bug, reviewers should be aware that this code path has a correctness issue that should be fixed.