|WARNING| pw168447 [PATCH 12/13] net/txgbe: fix CR/KR link training and recovery

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/168447

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#140: FILE: drivers/net/txgbe/base/txgbe_e56.h:438:
+#define E56PHY_FETX_FFE_TRAIN_CFG_0_KRT_FETX_INIT_FFE_CFG_0 1, 0

BUT SEE:

   do {} while (0) advice is over-stated in a few situations:

   The more obvious case is macros, like MODULE_PARM_DESC, invoked at
   file-scope, where C disallows code (it must be in functions).  See
   $exceptions if you have one to add by name.

   More troublesome is declarative macros used at top of new scope,
   like DECLARE_PER_CPU.  These might just compile with a do-while-0
   wrapper, but would be incorrect.  Most of these are handled by
   detecting struct,union,etc declaration primitives in $exceptions.

   Theres also macros called inside an if (block), which "return" an
   expression.  These cannot do-while, and need a ({}) wrapper.

   Enjoy this qualification while we work to improve our heuristics.

ERROR:C99_COMMENTS: do not use C99 // comments
#496: FILE: drivers/net/txgbe/txgbe_ethdev.c:3806:
+		intr->flags |= TXGBE_FLAG_NEED_AN_CONFIG;//aml40-to-do

total: 2 errors, 0 warnings, 0 checks, 349 lines checked
Warning in drivers/net/txgbe/base/txgbe_e56_bp.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t