|WARNING| [v2] net/sxe2: replace private mempool cache bypass with rte_mbuf_raw_free_bulk

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168453

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-27

# Review of DPDK Patch: net/sxe2 TX completion refactoring

## Summary
This patch replaces a private mempool cache bypass with `rte_mbuf_raw_free_bulk()` in the AVX-512 TX completion path. The patch correctly eliminates dead code and properly uses the DPDK API.

---

## Errors

**1. `rte_mbuf_raw_free_bulk()` used on Tx burst path with potentially mixed-pool mbufs**

Tx burst functions receive mbufs submitted by the application, which may originate from different mempools. The `RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE` offload only guarantees that mbufs have refcnt==1 and come from a single mempool *per burst*, but the driver cannot assume all mbufs in the `buffer[]` array come from the same pool as `buffer[0].mbuf->pool`.

`rte_mbuf_raw_free_bulk()` takes an explicit mempool parameter and calls `rte_mempool_put_bulk()` directly on that single pool. If any mbuf in the array comes from a different pool, it will be returned to the wrong pool, corrupting pool accounting.

The fast-free guarantee states "single pool" meaning the application promises all mbufs in a *given transmit burst* come from one pool, but the completion path may accumulate mbufs across multiple bursts submitted by the application. The driver reads `buffer[0].mbuf->pool` and assumes all mbufs in `buffer[0..rs_thresh-1]` come from that pool, which is not guaranteed.

**Fix**: Use `rte_pktmbuf_free_bulk()` instead, which batches mbufs by pool internally and is safe for mixed pools:

```c
/* GOOD - safe for mixed pools */
rte_pktmbuf_free_bulk((struct rte_mbuf **)buffer, rs_thresh);
```

Or verify all mbufs in the buffer come from the same pool before calling `rte_mbuf_raw_free_bulk()`:

```c
/* Check all mbufs are from the same pool */
for (i = 1; i < rs_thresh; i++) {
	if (unlikely(buffer[i].mbuf->pool != mp)) {
		/* Mixed pools - fall through to normal path */
		goto normal;
	}
}
rte_mbuf_raw_free_bulk(mp, (void *)buffer, rs_thresh);
```

---

## Warnings

None.

---

## Info

None.