|WARNING| [v2,4/4] net/qede: remove unused app version variable

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168626

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-29

# Review of DPDK Patch Series

## PATCH 1/4: common/dpaax: fix unused variable warning in non-debug build

**No issues found.**

The patch correctly addresses an unused variable warning by making the non-debug `DPAAX_HWWARN` macro consume its condition argument. The use of `RTE_SET_USED()` is the standard DPDK pattern for this scenario.

---

## PATCH 2/4: bus/dpaa: remove unused qman_clk variable

**No issues found.**

The patch removes a write-only global variable and its dead store. The removal is straightforward and correct.

---

## PATCH 3/4: common/zsda: remove unused device counter

**No issues found.**

The patch removes a write-only counter that is incremented/decremented but never read. The removal is correct.

---

## PATCH 4/4: net/qede: remove unused app version variable

### Errors

**Use-after-free potential in `qed_read_fw_info()`** (moderate confidence ~60%)

In `qede_debug.c`, the function `qed_read_fw_info()` is retained but `qed_dbg_set_app_ver()` which sets `s_app_ver` is removed. If `qed_read_fw_info()` or any other remaining code accesses `s_app_ver`, this creates a use-after-free or uninitialized variable issue.

The patch shows `qed_read_fw_info()` in the diff context but does not show its body. Verify that:
1. `qed_read_fw_info()` does not read `s_app_ver`
2. No other functions in `qede_debug.c` read `s_app_ver`
3. The variable is truly write-only

If `s_app_ver` is read anywhere, removing `qed_dbg_set_app_ver()` without also removing those reads will cause a bug.

**Recommended action:** Grep the full file for references to `s_app_ver`. If it is only written and never read (as the commit message claims), the patch is correct. If it is read, either:
- Remove those reads as well, or
- Keep `qed_dbg_set_app_ver()` and document why the variable must remain

---

## Summary

- **Patches 1-3:** Clean, correct fixes for unused variable warnings
- **Patch 4:** Requires verification that `s_app_ver` is truly never read. If it is read elsewhere in the file, this patch introduces a correctness bug.