|WARNING| [v3] net/dpaa: fix Rx queue shutdown before init

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168711

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-08-31

# DPDK Patch Review

## Summary
The patch fixes a correctness bug where `dpaa_eth_rx_queue_setup()` was shutting down a live frame queue that had already been initialized, breaking Rx. The shutdown is moved to the correct location in `dpaa_dev_init()` where it cleans up leftover state from a previous run.

---

## Correctness Issues

**No correctness bugs identified.**

The patch correctly moves the `qman_shutdown_fq()` call from the wrong location (where it shut down a live queue) to the right location (cleanup before initialization). This fixes the bug described.

---

## Style Issues

### Error: Missing NULL pointer check

**Line:** `qman_shutdown_fq(fqid);` (new call in `dpaa_dev_init()`)

**Issue:** The `qman_shutdown_fq()` function may fail or require validation of the `fqid` parameter, but there is no error check on the return value.

**Context:** The original code in `dpaa_eth_rx_queue_setup()` also did not check the return value, so this is a pre-existing issue now moved to a new location. However, if `qman_shutdown_fq()` can fail (returns non-zero on error), ignoring the return value could silently allow initialization to proceed with a queue in an inconsistent state.

**Suggested fix:**
```c
ret = qman_shutdown_fq(fqid);
if (ret != 0) {
	DPAA_PMD_ERR("Failed to shutdown FQ 0x%x: %d", fqid, ret);
	/* Decide whether to return error or continue */
}
```

**Severity:** Warning (if `qman_shutdown_fq()` is documented to always succeed for valid `fqid`, this is acceptable; otherwise it's an error)

---

### Info: Comment style inconsistency

**Line:** The new multi-line comment uses the kernel style:
```c
/* Clean up a frame queue left behind by a previous run
 * before it is initialized.
 */
```

**DPDK standard:**
```c
/*
 * Clean up a frame queue left behind by a previous run
 * before it is initialized.
 */
```

**Suggested fix:** Use DPDK's standard multi-line comment format with opening `/*` on its own line.

---

## Process and Documentation

**No issues identified:**
- Patch targets a bug fix (appropriate for backport to stable)
- `Cc: stable at dpdk.org` is present
- `Fixes:` tag references the commit that introduced the bug
- The fix is minimal and scoped to the actual problem
- No ABI changes
- No new API
- No release notes needed (this is a driver bug fix with no user-visible API change)

---

## Final Assessment

**Errors:** 0  
**Warnings:** 1 (missing error check on `qman_shutdown_fq()` return value)  
**Info:** 1 (comment style)

The patch correctly fixes the described bug. The warning about the missing error check is a pre-existing issue in the original code that is now being moved; whether it should block this patch depends on whether `qman_shutdown_fq()` can actually fail for a valid `fqid` (driver maintainer knowledge required).