|WARNING| pw160779 [PATCH] vhost: fix use-after-free in fdset during shutdown

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/160779

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#172: FILE: lib/vhost/fd_man.c:155:
+       unsigned int val;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: lib/vhost/fd_man.c:156:
+       int i;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#175: FILE: lib/vhost/fd_man.c:158:
+       if (pfdset == NULL)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#175: FILE: lib/vhost/fd_man.c:158:
+       if (pfdset == NULL)
+               return;

ERROR:CODE_INDENT: code indent should use tabs where possible
#176: FILE: lib/vhost/fd_man.c:159:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#176: FILE: lib/vhost/fd_man.c:159:
+               return;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#179: FILE: lib/vhost/fd_man.c:162:
+       pfdset->destroy = true;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: lib/vhost/fd_man.c:165:
+       if (rte_thread_join(pfdset->tid, &val) != 0)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#182: FILE: lib/vhost/fd_man.c:165:
+       if (rte_thread_join(pfdset->tid, &val) != 0)
+               VHOST_FDMAN_LOG(ERR, "Failed to join %s event dispatch thread", pfdset->name);

ERROR:CODE_INDENT: code indent should use tabs where possible
#183: FILE: lib/vhost/fd_man.c:166:
+               VHOST_FDMAN_LOG(ERR, "Failed to join %s event dispatch thread", pfdset->name);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#183: FILE: lib/vhost/fd_man.c:166:
+               VHOST_FDMAN_LOG(ERR, "Failed to join %s event dispatch thread", pfdset->name);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: lib/vhost/fd_man.c:169:
+       close(pfdset->epfd);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: lib/vhost/fd_man.c:172:
+       pthread_mutex_lock(&fdsets_mutex);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: lib/vhost/fd_man.c:173:
+       for (i = 0; i < MAX_FDSETS; i++) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#190: FILE: lib/vhost/fd_man.c:173:
+       for (i = 0; i < MAX_FDSETS; i++) {
+               if (fdsets[i] == pfdset) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#191: FILE: lib/vhost/fd_man.c:174:
+               if (fdsets[i] == pfdset) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#191: FILE: lib/vhost/fd_man.c:174:
+               if (fdsets[i] == pfdset) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#191: FILE: lib/vhost/fd_man.c:174:
+               if (fdsets[i] == pfdset) {
+                       fdsets[i] = NULL;

ERROR:CODE_INDENT: code indent should use tabs where possible
#192: FILE: lib/vhost/fd_man.c:175:
+                       fdsets[i] = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#192: FILE: lib/vhost/fd_man.c:175:
+                       fdsets[i] = NULL;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#193: FILE: lib/vhost/fd_man.c:176:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#193: FILE: lib/vhost/fd_man.c:176:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#194: FILE: lib/vhost/fd_man.c:177:
+               }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: lib/vhost/fd_man.c:177:
+               }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: lib/vhost/fd_man.c:178:
+       }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: lib/vhost/fd_man.c:179:
+       pthread_mutex_unlock(&fdsets_mutex);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: lib/vhost/fd_man.c:182:
+       rte_free(pfdset);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: lib/vhost/socket.c:1215:
+       if (vhost_user.fdset != NULL) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#228: FILE: lib/vhost/socket.c:1215:
+       if (vhost_user.fdset != NULL) {
+               fdset_deinit(vhost_user.fdset);

ERROR:CODE_INDENT: code indent should use tabs where possible
#229: FILE: lib/vhost/socket.c:1216:
+               fdset_deinit(vhost_user.fdset);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: lib/vhost/socket.c:1216:
+               fdset_deinit(vhost_user.fdset);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: lib/vhost/socket.c:1217:
+               vhost_user.fdset = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: lib/vhost/socket.c:1217:
+               vhost_user.fdset = NULL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#231: FILE: lib/vhost/socket.c:1218:
+       }$

total: 8 errors, 26 warnings, 64 lines checked