|WARNING| net/vhost: support queue info query

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166441

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-01

# DPDK Patch Review

## Summary
This patch adds queue info query callbacks to the vhost PMD to report actual vring sizes negotiated with the virtio frontend. The implementation is straightforward and addresses a legitimate gap.

---

## Errors

None.

---

## Warnings

### 1. Missing error propagation and documentation
**Issue:** The functions silently fail when `rte_vhost_get_vhost_vring()` returns an error, leaving `qinfo->nb_desc` at 0 without indicating an error to the caller.

**Why it matters:** The caller cannot distinguish between "queue not yet configured" (legitimate) and "failed to query queue" (unexpected error). This makes debugging difficult.

**Suggested fix:** Either:
- Return the error code from `rte_vhost_get_vhost_vring()` and let the caller handle it, OR
- Document that 0 is returned when the queue is not ready or on error

Since the callbacks are `void` returning, add a comment explaining the 0 return semantics:
```c
/* nb_desc is set to 0 if the vring is not yet configured or on error */
qinfo->nb_desc = 0;
```

### 2. Missing explicit comparison against NULL and -1
**Issue:** The code uses implicit checks `if (vq == NULL)` and `if (vq->vid < 0)` which comply with DPDK style for NULL and integer comparisons.

**CORRECTION:** This is actually correct per DPDK style. No issue here. (Item deleted per guidelines.)

### 3. Missing release notes entry
**Issue:** This patch adds new device operations (`rxq_info_get`, `txq_info_get`) which are part of the public PMD API surface. API changes require release notes.

**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_26_07.rst` (assuming 26.07 is current):
```rst
* **Updated vhost PMD.**

  * Added support for ``rxq_info_get`` and ``txq_info_get`` callbacks to query
    the negotiated vring size.
```

### 4. Missing PMD features documentation update
**Issue:** The patch adds support for querying queue info, which should be reflected in the vhost PMD features matrix at `doc/guides/nics/features/vhost.ini`.

**Suggested fix:** If `doc/guides/nics/features.rst` defines a feature for queue info query capability, add it to `doc/guides/nics/features/vhost.ini`. If no such feature exists, this warning can be ignored.

---

## Info

### 1. Consider adding bounds check on queue_id
**Observation:** The functions directly index `dev->data->rx_queues[rx_queue_id]` and `dev->data->tx_queues[tx_queue_id]` without verifying the queue_id is within bounds.

**Consideration:** If the ethdev layer already validates queue_id before calling these callbacks, this is safe. Otherwise, consider adding:
```c
if (rx_queue_id >= dev->data->nb_rx_queues)
    return;
```

This is an **Info** level suggestion only if bounds checking is not guaranteed by the caller.

---

## Correctness Verification

**Resource management:** No allocations or acquisitions; no cleanup needed.   
**Error paths:** Errors from `rte_vhost_get_vhost_vring()` are silently absorbed. Documented above as Warning #1.  
**NULL dereferences:** `vq` is checked before dereference.   
**Race conditions:** Read-only query of negotiated vring state; no shared mutable state.   
**Integer overflows:** `vring.size` is a descriptor count; no arithmetic operations.   

---

## Final Assessment

The patch is functionally correct. The primary concerns are:
1. Missing release notes (Warning)
2. Silent error handling without documentation (Warning)
3. Possibly missing features matrix update (Warning)

These should be addressed before merging, but the code itself does not have correctness bugs.