|WARNING| net/iavf: fix QinQ handling when only inner VLAN capability is supported

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166466

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-01

# DPDK Patch Review

## Patch Information
- **Subject:** net/iavf: fix QinQ handling when only inner VLAN capability is supported
- **Author:** Anurag Mandal <anurag.mandal at intel.com>
- **Target:** drivers/net/intel/iavf/iavf_vchnl.c

---

## Summary

The patch addresses VLAN stripping/insertion logic when hardware reports single VLAN capabilities through inner VLAN rather than outer VLAN. The core change removes the `qinq &&` condition from inner VLAN capability checks, allowing the code to fall through to inner VLAN handling when outer VLAN is not available.

---

## Review Findings

### Correctness Issues

**None identified.** The logic changes appear sound:
- Removes redundant `qinq &&` guard on inner capability checks
- Preserves outer VLAN preference when both outer and inner capabilities exist
- Falls back to inner VLAN when outer is unavailable
- Error path (`return -ENOTSUP`) remains intact when neither capability is present

### Code Style

**No issues found.**
- Indentation and formatting conform to DPDK style
- Boolean expressions use explicit bitwise checks (not implicit truthiness)
- Comment updates accurately describe the new behavior

### Documentation

**Warning:** Missing update to release notes.

**Rationale:** This is a bug fix that changes driver behavior and capability handling. The fix affects how the driver interprets hardware capabilities (falling back to inner VLAN when only inner is reported). Release notes should document this behavioral change.

**Suggested fix:** Add entry to `doc/guides/rel_notes/release_25_11.rst` (or current release notes file):

```rst
* **Fixed iavf QinQ handling for inner-only VLAN capabilities.**

  Fixed VLAN strip/insert operations in the iavf driver to correctly handle
  hardware that reports single VLAN capabilities through inner VLAN rather
  than outer VLAN registers.
```

### Process Compliance

**No issues.**
- Includes `Cc: stable at dpdk.org` (appropriate for bug fix)
- Fixes tags reference original commits
- Signed-off-by present

---

## Review Summary

The patch is **technically correct** and improves hardware capability handling. The only issue is the missing release notes update, which should be added before merging.

**Severity:** Warning (missing documentation)  
**Action:** Add release notes entry as shown above