|SUCCESS| app/testpmd: fix flow cfg double-free after reattach

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/166567

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-06

# DPDK Patch Review

## Summary
This patch fixes a double-free vulnerability in testpmd when a port is closed and then reattached. The fix is correct and addresses a real use-after-free scenario.

---

## Correctness Review

###  **PASS** - No correctness bugs found

The patch correctly fixes the double-free issue:
- After `free(port->job_list)`, the pointer is properly set to NULL
- The `queue_nb` field is reset to prevent stale metadata
- This prevents the dangling pointer dereference in `port_flow_configure()` on reattach

The fix follows the standard DPDK pattern for resource cleanup.

---

## Code Style Review

###  **PASS** - Style compliant

- Proper indentation (tabs for indentation)
- No trailing whitespace
- Simple, clear fix without unnecessary complexity
- Function remains focused on its single responsibility

---

## API and Documentation Review

### i **Info** - Release notes not required

This is a bug fix in the testpmd application (`app/test-pmd/`), not a library or driver change. The `Fixes:` tag and `Cc: stable at dpdk.org` are correctly present. Release notes are not required for test application fixes.

---

## Overall Assessment

**APPROVED** - This patch is correct and ready for merging.

The fix properly addresses the use-after-free vulnerability by ensuring that freed resources are properly marked as invalid. The pattern of setting pointers to NULL after free and resetting related counters is a standard defensive programming practice.

---

## Verdict

**No issues found.** The patch correctly fixes a real double-free bug, follows DPDK coding standards, and includes appropriate stable backport tags.